Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1018853004: Some CompilationInfo-related cleanup. (Closed)

Created:
5 years, 9 months ago by Sven Panne
Modified:
5 years, 9 months ago
Reviewers:
Michael Starzinger
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Some CompilationInfo-related cleanup. Use a delegating constructor for CompilationInfo, reducing duplicated code. Simplified handling of InlinedFunctionInfos on the way: When we start compiling, we have bigger things to worry about than a default vector. Reduced the usage of a SharedFunctionInfo for compiling, this is a slighty strange concept. Committed: https://crrev.com/e396f538d0f549fb82ce24c7780139a7c4df9954 Cr-Commit-Position: refs/heads/master@{#27299}

Patch Set 1 #

Patch Set 2 : Make ASAN happy. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -93 lines) Patch
M src/compiler.h View 5 chunks +7 lines, -12 lines 0 comments Download
M src/compiler.cc View 1 9 chunks +45 lines, -73 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M src/parser.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Sven Panne
5 years, 9 months ago (2015-03-19 10:14:07 UTC) #2
Michael Starzinger
LGTM.
5 years, 9 months ago (2015-03-19 10:30:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018853004/20001
5 years, 9 months ago (2015-03-19 11:57:42 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 12:39:48 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 12:40:17 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e396f538d0f549fb82ce24c7780139a7c4df9954
Cr-Commit-Position: refs/heads/master@{#27299}

Powered by Google App Engine
This is Rietveld 408576698