Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Unified Diff: src/compiler.h

Issue 1018853004: Some CompilationInfo-related cleanup. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Make ASAN happy. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.h
diff --git a/src/compiler.h b/src/compiler.h
index 56bbf3778d8f0a75c90c4f6ca70f880abcf6d377..e58562664732af04b5fb4fa589440ec30b5482bc 100644
--- a/src/compiler.h
+++ b/src/compiler.h
@@ -346,13 +346,8 @@ class CompilationInfo {
return result;
}
- std::vector<InlinedFunctionInfo>* inlined_function_infos() {
- return inlined_function_infos_;
- }
- std::vector<InlinedFunctionInfo>* ReleaseInlinedFunctionInfos() {
- std::vector<InlinedFunctionInfo>* tmp = inlined_function_infos_;
- inlined_function_infos_ = NULL;
- return tmp;
+ int start_position_for(uint32_t inlining_id) {
+ return inlined_function_infos_.at(inlining_id).start_position;
}
void LogDeoptCallPosition(int pc_offset, int inlining_id);
@@ -405,8 +400,6 @@ class CompilationInfo {
}
private:
- Isolate* isolate_;
-
// Compilation mode.
// BASE is generated by the full codegen, optionally prepared for bailouts.
// OPTIMIZE is optimized code generated by the Hydrogen-based backend.
@@ -419,7 +412,10 @@ class CompilationInfo {
STUB
};
- void Initialize(Isolate* isolate, Mode mode, Zone* zone);
+ CompilationInfo(ParseInfo* parse_info, CodeStub* code_stub, Mode mode,
+ Isolate* isolate, Zone* zone);
+
+ Isolate* isolate_;
void SetMode(Mode mode) {
mode_ = mode;
@@ -464,7 +460,7 @@ class CompilationInfo {
int prologue_offset_;
List<OffsetRange>* no_frame_ranges_;
- std::vector<InlinedFunctionInfo>* inlined_function_infos_;
+ std::vector<InlinedFunctionInfo> inlined_function_infos_;
bool track_positions_;
// A copy of shared_info()->opt_count() to avoid handle deref
@@ -493,7 +489,6 @@ class CompilationInfo {
class CompilationInfoWithZone: public CompilationInfo {
public:
explicit CompilationInfoWithZone(Handle<Script> script);
- explicit CompilationInfoWithZone(Handle<SharedFunctionInfo> shared_info);
explicit CompilationInfoWithZone(Handle<JSFunction> closure);
CompilationInfoWithZone(CodeStub* stub, Isolate* isolate)
: CompilationInfo(stub, isolate, &zone_) {}
« no previous file with comments | « no previous file | src/compiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698