Removing chrome.pushMessaging API

chrome/browser/background/background_mode_manager_unittest.cc

Index: chrome/browser/background/background_mode_manager_unittest.cc
diff --git a/chrome/browser/background/background_mode_manager_unittest.cc b/chrome/browser/background/background_mode_manager_unittest.cc
index 94a1d853180b111df14d9ef8a6850ce1e525a224..7b5850325e73e3af1c3fe55b10043225e9df126c 100644
--- a/chrome/browser/background/background_mode_manager_unittest.cc
+++ b/chrome/browser/background/background_mode_manager_unittest.cc
@@ -873,15 +873,6 @@ TEST_F(BackgroundModeManagerWithExtensionsTest, BalloonDisplay) {
         "\"permissions\": [\"background\"]}",
         "ID-2"));
 
-  scoped_refptr<extensions::Extension> ephemeral_app(
-    CreateExtension(
-        extensions::Manifest::COMMAND_LINE,
-        "{\"name\": \"Ephemeral App\", "
-        "\"version\": \"1.0\","
-        "\"manifest_version\": 2,"
-        "\"permissions\": [\"pushMessaging\"]}",
-        "ID-3"));
-
   static_cast<extensions::TestExtensionSystem*>(
       extensions::ExtensionSystem::Get(profile_))
       ->CreateExtensionService(base::CommandLine::ForCurrentProcess(),
@@ -923,14 +914,4 @@ TEST_F(BackgroundModeManagerWithExtensionsTest, BalloonDisplay) {
   // show the balloon.
   service->AddExtension(upgraded_no_bg_ext_has_bg.get());
   EXPECT_TRUE(manager_->HasShownBalloon());
-
-  // Installing an ephemeral app should not show the balloon.
-  manager_->SetHasShownBalloon(false);

[Andrew T Wilson (Slow), 2015/03/19 07:18:38]

So, I'm not that familiar with this "ephemeral app" stuff (don't think I was
looped in when it was added), but it looks like we no longer test this
functionality? Did ephemeral apps go away now that we've removed push messaging?
Or should you change this test to not rely on push messaging permission, but to
still test ephemeral apps?

[benwells, 2015/03/20 00:39:12]

Ephemeral apps were never released. I'm planning to delete the code soon so this
is fine.

-  AddEphemeralApp(ephemeral_app.get(), service);
-  EXPECT_FALSE(manager_->HasShownBalloon());
-
-  // Promoting the ephemeral app to a regular installed app should now show
-  // the balloon.
-  service->PromoteEphemeralApp(ephemeral_app.get(), false /* from sync */);
-  EXPECT_TRUE(manager_->HasShownBalloon());
 }