Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(666)

Issue 1018613002: Fix PasswordForm operator== and operator<< and update one reliant test. (Closed)

Created:
5 years, 9 months ago by engedy
Modified:
5 years, 9 months ago
CC:
chromium-reviews, estade+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist-passwords_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@throttling
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix PasswordForm operator== and operator<< and update one reliant test. BUG=437865 Committed: https://crrev.com/09e87d8debb588ae7e818198bbaa0c59bc74e4c6 Cr-Commit-Position: refs/heads/master@{#320944}

Patch Set 1 : #

Patch Set 2 : Undo clang formatting, and changes to matcher. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M components/autofill/core/common/password_form.cc View 1 2 chunks +4 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_form_manager_unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
engedy
Hi Vaclav, could you please take a quick look?
5 years, 9 months ago (2015-03-17 16:06:32 UTC) #5
vabr (Chromium)
LGTM, Thanks for fixing this! Vaclav
5 years, 9 months ago (2015-03-17 16:31:24 UTC) #6
Mike West
LGTM2, FWIW.
5 years, 9 months ago (2015-03-17 16:34:45 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018613002/40001
5 years, 9 months ago (2015-03-17 17:30:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:40001)
5 years, 9 months ago (2015-03-17 18:22:00 UTC) #11
commit-bot: I haz the power
5 years, 9 months ago (2015-03-17 18:26:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09e87d8debb588ae7e818198bbaa0c59bc74e4c6
Cr-Commit-Position: refs/heads/master@{#320944}

Powered by Google App Engine
This is Rietveld 408576698