Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Unified Diff: components/autofill/core/common/password_form.cc

Issue 1018613002: Fix PasswordForm operator== and operator<< and update one reliant test. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@throttling
Patch Set: Undo clang formatting, and changes to matcher. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/password_form.cc
diff --git a/components/autofill/core/common/password_form.cc b/components/autofill/core/common/password_form.cc
index 3ff8447a069f2dc5ad457b86b2b08a51e14333f7..066899e943b5a7bdc0e29c105b10933baeaa181f 100644
--- a/components/autofill/core/common/password_form.cc
+++ b/components/autofill/core/common/password_form.cc
@@ -32,7 +32,9 @@ bool PasswordForm::IsPublicSuffixMatch() const {
}
bool PasswordForm::operator==(const PasswordForm& form) const {
- return signon_realm == form.signon_realm &&
+ return scheme == form.scheme &&
+ signon_realm == form.signon_realm &&
+ original_signon_realm == form.original_signon_realm &&
origin == form.origin &&
action == form.action &&
submit_element == form.submit_element &&
@@ -67,6 +69,7 @@ bool PasswordForm::operator!=(const PasswordForm& form) const {
std::ostream& operator<<(std::ostream& os, const PasswordForm& form) {
return os << "scheme: " << form.scheme
<< " signon_realm: " << form.signon_realm
+ << " original_signon_realm: " << form.original_signon_realm
<< " origin: " << form.origin
<< " action: " << form.action
<< " submit_element: " << base::UTF16ToUTF8(form.submit_element)
« no previous file with comments | « no previous file | components/password_manager/core/browser/password_form_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698