Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 1018593002: Introduce UdevDeviceGetSysattrValue (Closed)

Created:
5 years, 9 months ago by Adam Goode
Modified:
5 years, 9 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce UdevDeviceGetSysattrValue, which is the same as UdevDeviceGetPropertyValue but for sysattrs. Use this in places where NULL is not an appropriate return value (such as assignment to std::string). Committed: https://crrev.com/df367dd86b9ad686d314f4664ae66674a1f700f0 Cr-Commit-Position: refs/heads/master@{#321043}

Patch Set 1 #

Patch Set 2 : Fix compile issue #

Total comments: 2

Patch Set 3 : Omit device:: in udev.cc for local functions #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -6 lines) Patch
M chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M components/storage_monitor/storage_monitor_linux.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M device/udev_linux/udev.h View 1 chunk +5 lines, -0 lines 0 comments Download
M device/udev_linux/udev.cc View 1 2 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Adam Goode
5 years, 9 months ago (2015-03-17 14:47:12 UTC) #2
Lei Zhang
lgtm https://codereview.chromium.org/1018593002/diff/20001/device/udev_linux/udev.cc File device/udev_linux/udev.cc (right): https://codereview.chromium.org/1018593002/diff/20001/device/udev_linux/udev.cc#newcode161 device/udev_linux/udev.cc:161: device::udev_device_get_property_value(udev_device, key)); nit: no need for device:: within ...
5 years, 9 months ago (2015-03-17 18:54:18 UTC) #3
Adam Goode
https://codereview.chromium.org/1018593002/diff/20001/device/udev_linux/udev.cc File device/udev_linux/udev.cc (right): https://codereview.chromium.org/1018593002/diff/20001/device/udev_linux/udev.cc#newcode161 device/udev_linux/udev.cc:161: device::udev_device_get_property_value(udev_device, key)); On 2015/03/17 at 18:54:18, Lei Zhang wrote: ...
5 years, 9 months ago (2015-03-17 20:19:14 UTC) #4
Ken Rockot(use gerrit already)
lgtm
5 years, 9 months ago (2015-03-17 20:21:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018593002/40001
5 years, 9 months ago (2015-03-18 00:50:47 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-18 01:25:41 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 01:26:31 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/df367dd86b9ad686d314f4664ae66674a1f700f0
Cr-Commit-Position: refs/heads/master@{#321043}

Powered by Google App Engine
This is Rietveld 408576698