chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc - Issue 1018593002: Introduce UdevDeviceGetSysattrValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

Issue 1018593002: Introduce UdevDeviceGetSysattrValue (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Omit device:: in udev.cc for local functions Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

diff --git a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

index 4bd7680a4316e4a167b8cf424ca7a02837a7fe27..3cc3ff989c2d5724df4e3d4bfe10ff2f5e872656 100644

--- a/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

+++ b/chrome/browser/extensions/api/image_writer_private/removable_storage_provider_linux.cc

@@ -91,9 +91,9 @@ bool RemovableStorageProvider::PopulateDeviceList(

linked_ptr<api::image_writer_private::RemovableStorageDevice> device_item(

new api::image_writer_private::RemovableStorageDevice());

device_item->vendor =

- device::udev_device_get_sysattr_value(parent_device, "vendor");

+ device::UdevDeviceGetSysattrValue(parent_device, "vendor");

device_item->model =

- device::udev_device_get_sysattr_value(parent_device, "model");

+ device::UdevDeviceGetSysattrValue(parent_device, "model");

// TODO (smaskell): Don't expose raw device path

device_item->storage_unit_id =

device::udev_device_get_devnode(cur_device.get());

« no previous file with comments | « no previous file | components/storage_monitor/storage_monitor_linux.cc » ('j') | no next file with comments »