Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1018423003: Sk2x for NEON (Closed)

Created:
5 years, 9 months ago by mtklein_C
Modified:
5 years, 9 months ago
Reviewers:
msarett, mtklein
CC:
reviews_skia.org, reed1
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sk2x for NEON Also decreases the precision of Sk4f::rsqrt() for speed, keeping Sk4f::sqrt() the same: instead of doing two estimation steps in rsqrt(), do one there and one more in sqrt(). Tests pass on my Nexus 7. float64x2_t is still a TODO for when I get a hold of a Nexus 9. BUG=skia: Committed: https://skia.googlesource.com/skia/+/5553bedf603e1f1a55d2fd6c70c2ca3a831b3801

Patch Set 1 #

Patch Set 2 : unused header #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -5 lines) Patch
M src/core/Sk2x.h View 3 chunks +6 lines, -0 lines 0 comments Download
A src/opts/Sk2x_neon.h View 1 1 chunk +93 lines, -0 lines 0 comments Download
M src/opts/Sk4x_neon.h View 1 chunk +9 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
mtklein_C
5 years, 9 months ago (2015-03-19 18:41:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018423003/1
5 years, 9 months ago (2015-03-19 18:41:26 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 9 months ago (2015-03-19 18:41:27 UTC) #5
msarett
lgtm
5 years, 9 months ago (2015-03-19 18:43:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018423003/20001
5 years, 9 months ago (2015-03-19 18:54:22 UTC) #8
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 19:08:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/5553bedf603e1f1a55d2fd6c70c2ca3a831b3801

Powered by Google App Engine
This is Rietveld 408576698