Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 101823005: vim -> vi. (Closed)

Created:
7 years ago by Daniel Bratell
Modified:
7 years ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, M-A Ruel, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/depot_tools.git@master
Visibility:
Public.

Description

vim -> vi. Not all Linux machines have vim preinstalled (example: Ubuntu 12.04). All machines have vi though. And it's actually vim but stripped down. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=239488

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gclient_utils.py View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Daniel Bratell
Just a tiny change to fallback code. The fallback editor on Linux is vim but ...
7 years ago (2013-12-09 14:19:15 UTC) #1
M-A Ruel
lgtm
7 years ago (2013-12-09 15:03:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bratell@opera.com/101823005/1
7 years ago (2013-12-09 15:03:41 UTC) #3
commit-bot: I haz the power
7 years ago (2013-12-09 15:05:35 UTC) #4
Message was sent while issue was closed.
Change committed as 239488

Powered by Google App Engine
This is Rietveld 408576698