gclient_utils.py - Issue 101823005: vim -> vi. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(1)

My Issues | Starred Open | Closed | All

Unified Diff: gclient_utils.py

Issue 101823005: vim -> vi. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/depot_tools.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: gclient_utils.py

diff --git a/gclient_utils.py b/gclient_utils.py

index 498d358c9cea117caf062d298436949c90dea56f..0d5714acc00ac5f67407f6ff30dd46c37cc8fabb 100644

--- a/gclient_utils.py

+++ b/gclient_utils.py

@@ -797,7 +797,7 @@ def GetEditor(git, git_editor=None):

- core.editor git configuration variable (if supplied by git-cl)

- VISUAL environment variable

- EDITOR environment variable

- - vim (non-Windows) or notepad (Windows)

+ - vi (non-Windows) or notepad (Windows)

In the case of git-cl, this matches git's behaviour, except that it does not

include dumb terminal detection.

@@ -817,7 +817,7 @@ def GetEditor(git, git_editor=None):

if sys.platform.startswith('win'):

editor = 'notepad'

else:

- editor = 'vim'

+ editor = 'vi'

return editor

« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine

This is Rietveld 408576698