Drop queued IPC messages if the child process dies while spawning

Drop queued IPC messages if the child process dies while spawning.

BUG=464633
Committed: https://crrev.com/06aac8528bd34a12a16f03e3bf955fea90918b3d
Cr-Commit-Position: refs/heads/master@{#321878}

[lfg, 2015-03-19 21:00:19]

lfg@chromium.org changed reviewers:
+ jam@chromium.org

[lfg, 2015-03-19 21:00:19]

Hi jam@, can you please take a look?

This fixes a problem where if the renderer process dies while spawning, we may
have a queued RenderView creation message that will be re-sent when creating
another process while the RenderViewHost will also re-send the message. This
will make a duplicate RenderView in the renderer process, which triggers an
assert.

[jam, 2015-03-23 16:36:14]

nice find. lgtm with nit

https://codereview.chromium.org/1018043004/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_process_host_impl.cc (right):

https://codereview.chromium.org/1018043004/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_process_host_impl.cc:2069: while
(!queued_messages_.empty()) {
nit: use STLDeleteElements from stl_util.h

[lfg, 2015-03-23 17:26:44]

On 2015/03/23 16:36:14, jam wrote:
> nice find. lgtm with nit
> 
>
https://codereview.chromium.org/1018043004/diff/20001/content/browser/rendere...
> File content/browser/renderer_host/render_process_host_impl.cc (right):
> 
>
https://codereview.chromium.org/1018043004/diff/20001/content/browser/rendere...
> content/browser/renderer_host/render_process_host_impl.cc:2069: while
> (!queued_messages_.empty()) {
> nit: use STLDeleteElements from stl_util.h

We can't use STLDeleteElements to cleanup, queued_messages_ is defined as an
std::queue, which is not a standard STL container (it doesn't define begin, end
or clear), and the underlying container is not exposed publicly.

[lfg, 2015-03-23 20:54:42]

The CQ bit was checked by lfg@chromium.org

[commit-bot: I haz the power, 2015-03-23 20:54:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018043004/20001

[commit-bot: I haz the power, 2015-03-23 22:36:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-23 22:38:02]

Patchset 2 (id:??) landed as
https://crrev.com/06aac8528bd34a12a16f03e3bf955fea90918b3d
Cr-Commit-Position: refs/heads/master@{#321878}