content/browser/renderer_host/render_process_host_impl.cc - Issue 1018043004: Drop queued IPC messages if the child process dies while spawning

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_process_host_impl.cc

Issue 1018043004: Drop queued IPC messages if the child process dies while spawning (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: adding test Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/browser/renderer_host/render_process_host_impl.cc

diff --git a/content/browser/renderer_host/render_process_host_impl.cc b/content/browser/renderer_host/render_process_host_impl.cc

index 4152ce2689bc097b208359991371ffd99a31e634..fc93b45e882108fc822bbb3191a7cde2a2de3936 100644

--- a/content/browser/renderer_host/render_process_host_impl.cc

+++ b/content/browser/renderer_host/render_process_host_impl.cc

@@ -2066,6 +2066,10 @@ void RenderProcessHostImpl::ProcessDied(bool already_dead,

child_process_launcher_.reset();

channel_.reset();

+ while (!queued_messages_.empty()) {

jam 2015/03/23 16:36:14 nit: use STLDeleteElements from stl_util.h

+ delete queued_messages_.front();

+ queued_messages_.pop();

+ }

within_process_died_observer_ = true;

NotificationService::current()->Notify(

« no previous file with comments | « content/browser/renderer_host/render_process_host_impl.h ('k') | no next file » | no next file with comments »