Refactored the attributes modules of extension_view and web_view into guest_view_attributes.js.

Refactored the attributes modules of extension_view and web_view into guest_view_attributes.js.

This refactor removed a lot of unnecessary repeated code. The other guestview types (that currently do not have attributes modules) will be refactored to use guest_view_attributes as well in a subsequent patch.

BUG=466215
Committed: https://crrev.com/182fc580aeaf826d46bed5e4a89a307369b346b3
Cr-Commit-Position: refs/heads/master@{#321376}

[paulmeyer, 2015-03-18 19:43:21]

paulmeyer@chromium.org changed reviewers:
+ fsamuel@chromium.org

[paulmeyer, 2015-03-18 19:43:21]

+fsamuel@

[Fady Samuel, 2015-03-19 00:19:13]

lgtm + nit

https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_attributes.js (right):

https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_attributes.js:38:
Object.defineProperty(this.view.element, this.name, {
nit: Use $Object

[paulmeyer, 2015-03-19 14:29:04]

paulmeyer@chromium.org changed reviewers:
+ kalman@chromium.org

[paulmeyer, 2015-03-19 14:29:05]

+kalman@ for extensions_renderer_resources.grd and dispatcher.cc

https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resourc...
File extensions/renderer/resources/guest_view/guest_view_attributes.js (right):

https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resourc...
extensions/renderer/resources/guest_view/guest_view_attributes.js:38:
Object.defineProperty(this.view.element, this.name, {
On 2015/03/19 00:19:13, Fady Samuel wrote:
> nit: Use $Object

Done.

[not at google - send to devlin, 2015-03-19 15:41:46]

dispatcher/resources lgtm

[paulmeyer, 2015-03-19 15:42:05]

The CQ bit was checked by paulmeyer@chromium.org

[paulmeyer, 2015-03-19 15:42:05]

The patchset sent to the CQ was uploaded after l-g-t-m from fsamuel@chromium.org
Link to the patchset: https://codereview.chromium.org/1017863007/#ps20001
(title: "Addressed comment.")

[commit-bot: I haz the power, 2015-03-19 15:42:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017863007/20001

[commit-bot: I haz the power, 2015-03-19 16:44:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-19 16:45:30]

Patchset 2 (id:??) landed as
https://crrev.com/182fc580aeaf826d46bed5e4a89a307369b346b3
Cr-Commit-Position: refs/heads/master@{#321376}