Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issue 1017863007: Refactored the attributes modules of extension_view and web_view into guest_view_attributes.js. (Closed)

Created:
5 years, 9 months ago by paulmeyer
Modified:
5 years, 9 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactored the attributes modules of extension_view and web_view into guest_view_attributes.js. This refactor removed a lot of unnecessary repeated code. The other guestview types (that currently do not have attributes modules) will be refactored to use guest_view_attributes as well in a subsequent patch. BUG=466215 Committed: https://crrev.com/182fc580aeaf826d46bed5e4a89a307369b346b3 Cr-Commit-Position: refs/heads/master@{#321376}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed comment. #

Messages

Total messages: 11 (4 generated)
paulmeyer
+fsamuel@
5 years, 9 months ago (2015-03-18 19:43:21 UTC) #2
Fady Samuel
lgtm + nit https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resources/guest_view/guest_view_attributes.js File extensions/renderer/resources/guest_view/guest_view_attributes.js (right): https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resources/guest_view/guest_view_attributes.js#newcode38 extensions/renderer/resources/guest_view/guest_view_attributes.js:38: Object.defineProperty(this.view.element, this.name, { nit: Use $Object
5 years, 9 months ago (2015-03-19 00:19:13 UTC) #3
paulmeyer
+kalman@ for extensions_renderer_resources.grd and dispatcher.cc https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resources/guest_view/guest_view_attributes.js File extensions/renderer/resources/guest_view/guest_view_attributes.js (right): https://codereview.chromium.org/1017863007/diff/1/extensions/renderer/resources/guest_view/guest_view_attributes.js#newcode38 extensions/renderer/resources/guest_view/guest_view_attributes.js:38: Object.defineProperty(this.view.element, this.name, { On ...
5 years, 9 months ago (2015-03-19 14:29:05 UTC) #5
not at google - send to devlin
dispatcher/resources lgtm
5 years, 9 months ago (2015-03-19 15:41:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017863007/20001
5 years, 9 months ago (2015-03-19 15:42:25 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 16:44:07 UTC) #10
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 16:45:30 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/182fc580aeaf826d46bed5e4a89a307369b346b3
Cr-Commit-Position: refs/heads/master@{#321376}

Powered by Google App Engine
This is Rietveld 408576698