extensions/renderer/resources/guest_view/extension_view/extension_view.js - Issue 1017863007: Refactored the attributes modules of extension_view and web_view into guest_view_attributes.js.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/resources/guest_view/extension_view/extension_view.js

Issue 1017863007: Refactored the attributes modules of extension_view and web_view into guest_view_attributes.js. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comment. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/renderer/resources/extensions_renderer_resources.grd ('k') | extensions/renderer/resources/guest_view/extension_view/extension_view_attributes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/renderer/resources/guest_view/extension_view/extension_view.js

diff --git a/extensions/renderer/resources/guest_view/extension_view/extension_view.js b/extensions/renderer/resources/guest_view/extension_view/extension_view.js

index 931a5c4ec6b72a4da8a43c062ddded055903d77c..9a132548a32d7ab55104f9e5448d6d3197027cc7 100644

--- a/extensions/renderer/resources/guest_view/extension_view/extension_view.js

+++ b/extensions/renderer/resources/guest_view/extension_view/extension_view.js

@@ -57,7 +57,7 @@ ExtensionViewImpl.prototype.onElementDetached = function() {

// Reset all attributes.

for (var i in this.attributes) {

- this.attributes[i].reset();

+ this.attributes[i].setValueIgnoreMutation();

}

};