components/data_reduction_proxy/proto/BUILD.gn - Issue 1017853003: Add ClientConfig proto, and JSON generation/parsing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_reduction_proxy/proto/BUILD.gn

Issue 1017853003: Add ClientConfig proto, and JSON generation/parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting and unit test fix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc ('k') | components/data_reduction_proxy/proto/client_config.proto » ('j') | components/data_reduction_proxy/proto/client_config.proto » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_reduction_proxy/proto/BUILD.gn

diff --git a/content/browser/notifications/BUILD.gn b/components/data_reduction_proxy/proto/BUILD.gn

similarity index 75%

copy from content/browser/notifications/BUILD.gn

copy to components/data_reduction_proxy/proto/BUILD.gn

index 0f6d5456988125873ebb894c8b61fe8383f46111..889c1067838d1e9f9de8724ac99dc15377ab540f 100644

--- a/content/browser/notifications/BUILD.gn

+++ b/components/data_reduction_proxy/proto/BUILD.gn

@@ -4,8 +4,8 @@

import("//third_party/protobuf/proto_library.gni")

-proto_library("notification_proto") {

+proto_library("data_reduction_proxy_proto") {

sclittle 2015/03/18 20:31:51 What needs to depend on this proto? Could this "pr

jeremyim 2015/03/20 16:21:12 The convention for several other components seems

sources = [

- "notification_database_data.proto",

+ "client_config.proto",

]

}