components/data_reduction_proxy/proto/BUILD.gn - Issue 1017853003: Add ClientConfig proto, and JSON generation/parsing.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/data_reduction_proxy/proto/BUILD.gn

Issue 1017853003: Add ClientConfig proto, and JSON generation/parsing. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting and unit test fix. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« components/data_reduction_proxy/core/common/data_reduction_proxy_params.cc ('K') | « components/data_reduction_proxy/core/common/data_reduction_proxy_params_unittest.cc ('k') | components/data_reduction_proxy/proto/client_config.proto » ('j') | components/data_reduction_proxy/proto/client_config.proto » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 # Copyright 2015 The Chromium Authors. All rights reserved.	1 # Copyright 2015 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import("//third_party/protobuf/proto_library.gni")	5 import("//third_party/protobuf/proto_library.gni")

6	6

7 proto_library("notification_proto") {	7 proto_library("data_reduction_proxy_proto") {
	sclittle 2015/03/18 20:31:51 What needs to depend on this proto? Could this "pr What needs to depend on this proto? Could this "proto/" directory be put under core/? jeremyim 2015/03/20 16:21:12 The convention for several other components seems Show quoted text On 2015/03/18 20:31:51, sclittle wrote: > What needs to depend on this proto? Could this "proto/" directory be put under > core/? The convention for several other components seems to be to have proto files in a separate proto directory.
8 sources = [	8 sources = [

9 "notification_database_data.proto",	9 "client_config.proto",

10 ]	10 ]

11 }	11 }

OLD	NEW