[Icons NTP] Add path_index() to ParsedFallbackIconPath.

chrome/common/favicon/fallback_icon_url_parser.cc

Index: chrome/common/favicon/fallback_icon_url_parser.cc
diff --git a/chrome/common/favicon/fallback_icon_url_parser.cc b/chrome/common/favicon/fallback_icon_url_parser.cc
index 5a407c6bbb9aa068d2efda8efef1129c9c99a563..f91e39f6450d370b81c12160dd4d673306524b99 100644
--- a/chrome/common/favicon/fallback_icon_url_parser.cc
+++ b/chrome/common/favicon/fallback_icon_url_parser.cc
@@ -54,10 +54,15 @@ bool ParsedFallbackIconPath::Parse(const std::string& path) {
   if (!ParseSpecs(spec_str, &size_in_pixels_, &style_))
     return false;  // Parse failed.
 
-  // Extract URL, which may be empty (if first slash appears at the end).
-  std::string url_str = path.substr(slash + 1);
-  url_ = GURL(url_str);
-  return url_str.empty() || url_.is_valid();  // Allow empty URL.
+  // Need to store the index of the URL field, so Instant Extended can translate
+  // fallback icon URLs using advanced parameters.
+  // Example:
+  //   "chrome-search://fallback-icon/48/<renderer-id>/<most-visited-id>"
+  // would be translated to:
+  //   "chrome-search://fallback-icon/48/<most-visited-item-with-given-id>".

[beaudoin, 2015/03/18 00:05:38]

Same comment here as the previous CL. I believe this is not really a
url_string...

[huangs, 2015/03/18 18:38:49]

As before, prefer to defer to crbug.com/468320.

[beaudoin, 2015/03/18 19:03:18]

Acknowledged.

+  path_index_ = slash + 1;
+  url_string_ = path.substr(path_index_);
+  return true;
 }
 
 // static