[Icons NTP] Add path_index() to ParsedFallbackIconPath.

chrome/common/favicon/fallback_icon_url_parser.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/common/favicon/fallback_icon_url_parser.h"
 
 #include <algorithm>
 
 #include "base/logging.h"
 #include "base/macros.h"
@@ skipping 36 matching lines @@
   if (path.empty())
     return false;
 
   size_t slash = path.find("/", 0);
   if (slash == std::string::npos)
     return false;
   std::string spec_str = path.substr(0, slash);
   if (!ParseSpecs(spec_str, &size_in_pixels_, &style_))
     return false;  // Parse failed.
 
-  // Extract URL, which may be empty (if first slash appears at the end).
-  std::string url_str = path.substr(slash + 1);
-  url_ = GURL(url_str);
-  return url_str.empty() || url_.is_valid();  // Allow empty URL.
+  // Need to store the index of the URL field, so Instant Extended can translate
+  // fallback icon URLs using advanced parameters.
+  // Example:
+  //   "chrome-search://fallback-icon/48/<renderer-id>/<most-visited-id>"
+  // would be translated to:
+  //   "chrome-search://fallback-icon/48/<most-visited-item-with-given-id>".

[beaudoin, 2015/03/18 00:05:38]

Same comment here as the previous CL. I believe this is not really a
url_string...

[huangs, 2015/03/18 18:38:49]

As before, prefer to defer to crbug.com/468320.

[beaudoin, 2015/03/18 19:03:18]

Acknowledged.

+  path_index_ = slash + 1;
+  url_string_ = path.substr(path_index_);
+  return true;
 }
 
 // static
 bool ParsedFallbackIconPath::ParseSpecs(
     const std::string& specs_str,
     int *size,
     favicon_base::FallbackIconStyle* style) {
   DCHECK(size);
   DCHECK(style);
 
@@ skipping 51 matching lines @@
   SkColor temp_color = SK_ColorWHITE;
   const char* end = SkParse::FindColor(color_str.c_str(), &temp_color);
   if (end && !*end) {  // Successful if call succeeds and string is consumed.
     *color = temp_color;
     return true;
   }
   return false;
 }
 
 }  // namespace chrome