Source/core/rendering/RenderBlockLineLayout.cpp - Issue 101763008: Fix some problems reported by clang static analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/RenderBlockLineLayout.cpp

Issue 101763008: Fix some problems reported by clang static analyzer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/RenderBlockLineLayout.cpp

diff --git a/Source/core/rendering/RenderBlockLineLayout.cpp b/Source/core/rendering/RenderBlockLineLayout.cpp

index 51aa715df0427e990dba499109370ac8f06f0039..9d5635926f14395c257312652abc7240d2285f43 100644

--- a/Source/core/rendering/RenderBlockLineLayout.cpp

+++ b/Source/core/rendering/RenderBlockLineLayout.cpp

@@ -919,7 +919,7 @@ static inline void constructBidiRunsForSegment(InlineBidiResolver& topResolver,

LineMidpointState& isolatedLineMidpointState = isolatedResolver.midpointState();

isolatedLineMidpointState = topResolver.midpointStateForIsolatedRun(isolatedRun);

EUnicodeBidi unicodeBidi = isolatedInline->style()->unicodeBidi();

- TextDirection direction = isolatedInline->style()->direction();

+ TextDirection direction;

if (unicodeBidi == Plaintext) {

if (isNewUBAParagraph)

direction = determinePlaintextDirectionality(isolatedInline, startObj);

« no previous file with comments | « Source/core/rendering/InlineTextBox.cpp ('k') | Source/core/rendering/RenderLayer.cpp » ('j') | no next file with comments »