sky/engine/bindings/scripts/dart_types.py - Issue 1017593005: Add a basic custom painting facility to Sky

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sky/engine/bindings/scripts/dart_types.py

Issue 1017593005: Add a basic custom painting facility to Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Add missing files Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sky/engine/bindings/scripts/dart_types.py

diff --git a/sky/engine/bindings/scripts/dart_types.py b/sky/engine/bindings/scripts/dart_types.py

index c58ad59e62bf626e9c4464473dae41f90a5d768f..83335aa40ed1acfc46735c3b18dc023e3aeb4cbb 100644

--- a/sky/engine/bindings/scripts/dart_types.py

+++ b/sky/engine/bindings/scripts/dart_types.py

@@ -718,7 +718,7 @@ CPP_VALUE_TO_DART_VALUE = {

'DartValue': 'DartConverter<DartValue*>::ToDart({cpp_value})',

# General

'array': 'VectorToDart({cpp_value})',

- 'DOMWrapper': 'Dart{idl_type}::toDart({cpp_value})',

+ 'DOMWrapper': 'DartConverter<{idl_type}*>::ToDart({cpp_value})',

}