Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Unified Diff: sky/engine/bindings/scripts/dart_callback_interface.py

Issue 1017593005: Add a basic custom painting facility to Sky (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Add missing files Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | sky/engine/bindings/scripts/dart_types.py » ('j') | sky/engine/core/dom/Element.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sky/engine/bindings/scripts/dart_callback_interface.py
diff --git a/sky/engine/bindings/scripts/dart_callback_interface.py b/sky/engine/bindings/scripts/dart_callback_interface.py
index 8ec81032a628a555d3a3f2e95fa82e2108d978dc..99f2ad625ba489c8c0a0d5d5cca49f0cc11c12d9 100644
--- a/sky/engine/bindings/scripts/dart_callback_interface.py
+++ b/sky/engine/bindings/scripts/dart_callback_interface.py
@@ -124,7 +124,12 @@ def generate_arguments_contents(arguments, call_with_this_handle):
for argument in arguments]
if call_with_this_handle:
argument_declarations.insert(0, 'ScriptValue thisValue')
+
+ dart_argument_declarations = [
+ '%s %s' % (dart_types.idl_type_to_dart_type(argument.idl_type), argument.name)
+ for argument in arguments]
return {
'argument_declarations': argument_declarations,
+ 'dart_argument_declarations': dart_argument_declarations,
'arguments': [generate_argument(argument) for argument in arguments],
}
« no previous file with comments | « no previous file | sky/engine/bindings/scripts/dart_types.py » ('j') | sky/engine/core/dom/Element.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698