Issue 1017563002: Sky shouldn't round font weights

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1017563002: Sky shouldn't round font weights (Closed)

Created:
5 years, 9 months ago by abarth-chromium

Modified:
5 years, 9 months ago

Reviewers:
eseidel

CC:
mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Sky shouldn't round font weights This CL updates our use of Skia's API for loading fonts to load exactly the font the developer asked for instead of rounding. R=eseidel@chromium.org BUG=https://github.com/domokit/mojo/issues/65 Committed: https://chromium.googlesource.com/external/mojo/+/15c96b386d5eaa88a253b8a96186924ca7c479bf

Patch Set 1 #

Total comments: 1

Patch Set 2 : comment and names #

Patch Set 3 : Works #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -6 lines)			Patch
	M	sky/engine/platform/fonts/skia/FontCacheSkia.cpp	View	1 2	2 chunks	+65 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

eseidel

lgtm https://codereview.chromium.org/1017563002/diff/1/sky/engine/platform/fonts/skia/FontCacheSkia.cpp File sky/engine/platform/fonts/skia/FontCacheSkia.cpp (right): https://codereview.chromium.org/1017563002/diff/1/sky/engine/platform/fonts/skia/FontCacheSkia.cpp#newcode112 sky/engine/platform/fonts/skia/FontCacheSkia.cpp:112: return static_cast<int>(stretch); I still might add a one-line ...

5 years, 9 months ago (2015-03-16 23:57:54 UTC) #2

abarth-chromium

5 years, 9 months ago (2015-03-17 16:50:24 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
15c96b386d5eaa88a253b8a96186924ca7c479bf (presubmit successful).

Expand Messages | Collapse Messages