Sky shouldn't round font weights

sky/engine/platform/fonts/skia/FontCacheSkia.cpp

 /*
  * Copyright (c) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 51 matching lines @@
 {
     SkAutoTUnref<SkFontConfigInterface> fci(SkFontConfigInterface::RefGlobal());
     SkFontConfigInterface::FontIdentity fontIdentity;
     fontIdentity.fID = fontconfigInterfaceId;
     return fci->openStream(fontIdentity);
 }
 #endif
 
 namespace blink {
 
+static int toSkiaWeight(FontWeight weight)
+{
+    switch (weight) {
+    case FontWeight100:
+        return 100;
+    case FontWeight200:
+        return 200;
+    case FontWeight300:
+        return 300;
+    case FontWeight400:
+        return 400;
+    case FontWeight500:
+        return 500;
+    case FontWeight600:
+        return 600;
+    case FontWeight700:
+        return 700;
+    case FontWeight800:
+        return 800;
+    case FontWeight900:
+        return 900;
+    }
+    ASSERT_NOT_REACHED();
+    return 400;
+}
+
+static SkFontStyle::Slant toSkiaSlant(FontStyle style)
+{
+    switch (style) {
+    case FontStyleNormal:
+        return SkFontStyle::kUpright_Slant;
+    case FontStyleItalic:
+        return SkFontStyle::kItalic_Slant;
+    }
+    ASSERT_NOT_REACHED();
+    return SkFontStyle::kUpright_Slant;
+}
+
+static int toSkiaWidth(FontStretch stretch)
+{
+    return static_cast<int>(stretch);

[eseidel, 2015/03/16 23:57:54]

I still might add a one-line comment.

+}
+
+static SkFontStyle toSkiaFontStyle(const FontDescription& fontDescription)
+{
+    return SkFontStyle(toSkiaWeight(fontDescription.weight()),
+                       toSkiaWidth(fontDescription.stretch()),
+                       toSkiaSlant(fontDescription.style()));
+}
+
 void FontCache::platformInit()
 {
 }
 
 PassRefPtr<SimpleFontData> FontCache::fallbackOnStandardFontStyle(
     const FontDescription& fontDescription, UChar32 character)
 {
     FontDescription substituteDescription(fontDescription);
     substituteDescription.setStyle(FontStyleNormal);
     substituteDescription.setWeight(FontWeightNormal);
@@ skipping 101 matching lines @@
     AtomicString family = creationParams.family();
     // If we're creating a fallback font (e.g. "-webkit-monospace"), convert the name into
     // the fallback name (like "monospace") that fontconfig understands.
     if (!family.length() || family.startsWith("-webkit-")) {
         name = getFallbackFontFamily(fontDescription).string().utf8();
     } else {
         // convert the name to utf8
         name = family.utf8();
     }
 
-    int style = SkTypeface::kNormal;
-    if (fontDescription.weight() >= FontWeight600)
-        style |= SkTypeface::kBold;
-    if (fontDescription.style())
-        style |= SkTypeface::kItalic;
-
-    // FIXME: Use m_fontManager, SkFontStyle and matchFamilyStyle instead of
-    // CreateFromName on all platforms.
-    return adoptRef(SkTypeface::CreateFromName(name.data(), static_cast<SkTypeface::Style>(style)));
+    RefPtr<SkFontMgr> fm = adoptRef(SkFontMgr::RefDefault());
+    return adoptRef(fm->matchFamilyStyle(name.data(), toSkiaFontStyle(fontDescription)));
 }
 
 #if !OS(WIN)
 FontPlatformData* FontCache::createFontPlatformData(const FontDescription& fontDescription, const FontFaceCreationParams& creationParams, float fontSize)
 {
     CString name;
     RefPtr<SkTypeface> tf(createTypeface(fontDescription, creationParams, name));
     if (!tf)
         return 0;
 
     FontPlatformData* result = new FontPlatformData(tf,
         name.data(),
         fontSize,
         (fontDescription.weight() >= FontWeight600 && !tf->isBold()) || fontDescription.isSyntheticBold(),
         (fontDescription.style() && !tf->isItalic()) || fontDescription.isSyntheticItalic(),
         fontDescription.orientation(),
         fontDescription.useSubpixelPositioning());
     return result;
 }
 #endif // !OS(WIN)
 
 } // namespace blink