Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: net/interfaces/proxy_resolver_service.mojom

Issue 1017453005: Add support for ProxyResolverErrorObserver to ProxyResolverMojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/net.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/interfaces/proxy_resolver_service.mojom
diff --git a/net/interfaces/proxy_resolver_service.mojom b/net/interfaces/proxy_resolver_service.mojom
index 57ab12137693af4247aab88c1dbd1b3aeabe8ea9..68f798e8e8964dc85756a169757c7f407b75bb4e 100644
--- a/net/interfaces/proxy_resolver_service.mojom
+++ b/net/interfaces/proxy_resolver_service.mojom
@@ -42,11 +42,16 @@ interface ProxyResolverRequestClient {
LoadStateChanged(int32 load_state);
};
+interface ProxyResolverErrorObserver {
+ OnPacScriptError(int32 line_number, string error);
+};
+
interface ProxyResolverFactory {
- // TODO(amistry): Add NetLog and ProxyResolverErrorObserver.
+ // TODO(amistry): Add NetLog.
CreateResolver(string pac_script,
ProxyResolver& resolver,
HostResolver host_resolver,
+ ProxyResolverErrorObserver? error_observer,
ProxyResolverFactoryRequestClient client);
};
« no previous file with comments | « net/BUILD.gn ('k') | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698