Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: net/interfaces/proxy_resolver_service.mojom

Issue 1017453005: Add support for ProxyResolverErrorObserver to ProxyResolverMojo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/BUILD.gn ('k') | net/net.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Put Mojo definitions into their own namespace to avoid collisions with C++ 5 // Put Mojo definitions into their own namespace to avoid collisions with C++
6 // definitions. 6 // definitions.
7 // TODO(amistry): Resolve the conflict between these two sets of definitions. 7 // TODO(amistry): Resolve the conflict between these two sets of definitions.
8 module net.interfaces; 8 module net.interfaces;
9 9
10 import "host_resolver_service.mojom"; 10 import "host_resolver_service.mojom";
(...skipping 24 matching lines...) Expand all
35 // client. 35 // client.
36 // TODO(amistry): Add BoundNetLog. 36 // TODO(amistry): Add BoundNetLog.
37 GetProxyForUrl(string url, ProxyResolverRequestClient client); 37 GetProxyForUrl(string url, ProxyResolverRequestClient client);
38 }; 38 };
39 39
40 interface ProxyResolverRequestClient { 40 interface ProxyResolverRequestClient {
41 ReportResult(int32 error, array<ProxyServer>? proxy_servers); 41 ReportResult(int32 error, array<ProxyServer>? proxy_servers);
42 LoadStateChanged(int32 load_state); 42 LoadStateChanged(int32 load_state);
43 }; 43 };
44 44
45 interface ProxyResolverErrorObserver {
46 OnPacScriptError(int32 line_number, string error);
47 };
48
45 interface ProxyResolverFactory { 49 interface ProxyResolverFactory {
46 // TODO(amistry): Add NetLog and ProxyResolverErrorObserver. 50 // TODO(amistry): Add NetLog.
47 CreateResolver(string pac_script, 51 CreateResolver(string pac_script,
48 ProxyResolver& resolver, 52 ProxyResolver& resolver,
49 HostResolver host_resolver, 53 HostResolver host_resolver,
54 ProxyResolverErrorObserver? error_observer,
50 ProxyResolverFactoryRequestClient client); 55 ProxyResolverFactoryRequestClient client);
51 }; 56 };
52 57
53 interface ProxyResolverFactoryRequestClient { 58 interface ProxyResolverFactoryRequestClient {
54 ReportResult(int32 error); 59 ReportResult(int32 error);
55 }; 60 };
OLDNEW
« no previous file with comments | « net/BUILD.gn ('k') | net/net.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698