Source/platform/LifecycleObserver.h - Issue 1017313002: Simplify handling of LocalFrame lifecycle notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/LifecycleObserver.h

Issue 1017313002: Simplify handling of LocalFrame lifecycle notifications. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: clear context on FDO::contextDestroyed() Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/LifecycleObserver.h

diff --git a/Source/platform/LifecycleObserver.h b/Source/platform/LifecycleObserver.h

index cc7dcc31fc07009a31fa29bfc722ec8a9f07c3dc..6637428da094e1f927fe49f5baeec6b75879bacb 100644

--- a/Source/platform/LifecycleObserver.h

+++ b/Source/platform/LifecycleObserver.h

@@ -37,17 +37,17 @@ class LifecycleObserver : public WillBeGarbageCollectedMixin {

public:

using Context = T;

- explicit LifecycleObserver(Context* context)

+ LifecycleObserver()

: m_lifecycleContext(nullptr)

{

}

+#if !ENABLE(OILPAN)

virtual ~LifecycleObserver()

{

-#if !ENABLE(OILPAN)

dispose();

-#endif

}

+#endif

DEFINE_INLINE_VIRTUAL_TRACE()

{