Source/core/page/PageLifecycleObserver.cpp - Issue 1017313002: Simplify handling of LocalFrame lifecycle notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/PageLifecycleObserver.cpp

Issue 1017313002: Simplify handling of LocalFrame lifecycle notifications. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: clear context on FDO::contextDestroyed() Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/page/PageLifecycleObserver.cpp

diff --git a/Source/core/page/PageLifecycleObserver.cpp b/Source/core/page/PageLifecycleObserver.cpp

index b1e74407b844381f1cda9be7d485632bd2864eb2..9aadac09475500fd000c79269bca26bb48267548 100644

--- a/Source/core/page/PageLifecycleObserver.cpp

+++ b/Source/core/page/PageLifecycleObserver.cpp

@@ -30,18 +30,8 @@

namespace blink {

PageLifecycleObserver::PageLifecycleObserver(Page* page)

haraken 2015/03/19 23:42:00 Nit: Can we probably inline this method and remove

- : LifecycleObserver<Page, PageLifecycleObserver, PageLifecycleNotifier>(page)

{

setContext(page);

}

-PageLifecycleObserver::~PageLifecycleObserver()

-Page* PageLifecycleObserver::page() const

- return static_cast<Page*>(lifecycleContext());

} // namespace blink