Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Issue 1017273002: Remove old references to cpu_arch, os from GN files. (Closed)

Created:
5 years, 9 months ago by Dirk Pranke
Modified:
5 years, 9 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove old references to cpu_arch, os from GN files. Now that os and cpu_arch are no longer needed or used anywhere. R=brettw@chromium.org, rockot@chromium.org BUG=344767 CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/c329085593402937717484c073086cb1c904f37b Cr-Commit-Position: refs/heads/master@{#322499}

Patch Set 1 #

Total comments: 3

Patch Set 2 : merge to #322476 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -43 lines) Patch
M build/config/BUILDCONFIG.gn View 1 4 chunks +4 lines, -30 lines 0 comments Download
M build/config/compiler/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M build/toolchain/gcc_toolchain.gni View 1 chunk +0 lines, -6 lines 0 comments Download
M build/toolchain/win/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M components/nacl/BUILD.gn View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
Dirk Pranke
https://codereview.chromium.org/1017273002/diff/1/third_party/mojo/src/mojo/public/mojo_application.gni File third_party/mojo/src/mojo/public/mojo_application.gni (right): https://codereview.chromium.org/1017273002/diff/1/third_party/mojo/src/mojo/public/mojo_application.gni#newcode158 third_party/mojo/src/mojo/public/mojo_application.gni:158: output = "${base_target_name}_${current_cpu}.nexe.mojo" I think this probably needs to ...
5 years, 9 months ago (2015-03-18 20:36:28 UTC) #2
Dirk Pranke
https://codereview.chromium.org/1017273002/diff/1/third_party/mojo/src/mojo/public/mojo_application.gni File third_party/mojo/src/mojo/public/mojo_application.gni (right): https://codereview.chromium.org/1017273002/diff/1/third_party/mojo/src/mojo/public/mojo_application.gni#newcode158 third_party/mojo/src/mojo/public/mojo_application.gni:158: output = "${base_target_name}_${current_cpu}.nexe.mojo" On 2015/03/18 20:36:27, Dirk Pranke wrote: ...
5 years, 9 months ago (2015-03-18 20:54:32 UTC) #3
Ken Rockot(use gerrit already)
lgtm https://codereview.chromium.org/1017273002/diff/1/third_party/mojo/src/mojo/public/mojo_application.gni File third_party/mojo/src/mojo/public/mojo_application.gni (right): https://codereview.chromium.org/1017273002/diff/1/third_party/mojo/src/mojo/public/mojo_application.gni#newcode158 third_party/mojo/src/mojo/public/mojo_application.gni:158: output = "${base_target_name}_${current_cpu}.nexe.mojo" On 2015/03/18 20:54:32, Dirk Pranke ...
5 years, 9 months ago (2015-03-18 20:58:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017273002/1
5 years, 9 months ago (2015-03-18 21:02:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gn_dbg on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_dbg/builds/220)
5 years, 9 months ago (2015-03-18 21:09:44 UTC) #8
brettw
lgtm
5 years, 9 months ago (2015-03-18 22:22:46 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017273002/1
5 years, 9 months ago (2015-03-19 01:41:17 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017273002/1
5 years, 9 months ago (2015-03-19 01:48:37 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/70212)
5 years, 9 months ago (2015-03-19 01:55:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017273002/20001
5 years, 9 months ago (2015-03-26 21:52:38 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-26 23:35:46 UTC) #20
commit-bot: I haz the power
5 years, 9 months ago (2015-03-26 23:36:43 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c329085593402937717484c073086cb1c904f37b
Cr-Commit-Position: refs/heads/master@{#322499}

Powered by Google App Engine
This is Rietveld 408576698