build/config/compiler/BUILD.gn - Issue 1017273002: Remove old references to cpu_arch, os from GN files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/compiler/BUILD.gn

Issue 1017273002: Remove old references to cpu_arch, os from GN files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: merge to #322476 Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/compiler/BUILD.gn

diff --git a/build/config/compiler/BUILD.gn b/build/config/compiler/BUILD.gn

index 42dc584116663456fa212ae6c3b7d4d4ce4704db..b2d615d42a7ff40f43fcb02de42abeac21ece020 100644

--- a/build/config/compiler/BUILD.gn

+++ b/build/config/compiler/BUILD.gn

@@ -573,7 +573,7 @@ config("runtime_library") {

# TODO(jdduke) Re-enable on mips after resolving linking

# issues with libc++ (crbug.com/456380).

- if (cpu_arch != "mipsel" && cpu_arch != "mips64el") {

+ if (current_cpu != "mipsel" && current_cpu != "mips64el") {

ldflags += [ "-Wl,--warn-shared-textrel" ]

}

ldflags += [ "-nostdlib" ]

@@ -983,7 +983,7 @@ if (is_win) {

# TODO(jdduke) Re-enable on mips after resolving linking

# issues with libc++ (crbug.com/456380).

- if (cpu_arch != "mipsel" && cpu_arch != "mips64el") {

+ if (current_cpu != "mipsel" && current_cpu != "mips64el") {

common_optimize_on_ldflags += [

# Warn in case of text relocations.

"-Wl,--warn-shared-textrel",

« no previous file with comments | « build/config/BUILDCONFIG.gn ('k') | build/toolchain/gcc_toolchain.gni » ('j') | no next file with comments »