[App banners] Be less strict about navigations

chrome/browser/banners/app_banner_settings_helper.h

Index: chrome/browser/banners/app_banner_settings_helper.h
diff --git a/chrome/browser/banners/app_banner_settings_helper.h b/chrome/browser/banners/app_banner_settings_helper.h
index 10b86fb7d1616c96b574e6bfda256037265cf096..533871cb103c90c3abefb51c010c036b3ba231eb 100644
--- a/chrome/browser/banners/app_banner_settings_helper.h
+++ b/chrome/browser/banners/app_banner_settings_helper.h
@@ -46,6 +46,9 @@ class AppBannerSettingsHelper {
     APP_BANNER_EVENT_NUM_EVENTS,
   };
 
+  // Returns whether or not the URLs match for everything except for the ref.
+  static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);

[benwells, 2015/03/19 07:18:55]

Why is this is AppBannerSettingsHelper? Seems like it should go in
AppBannerManager or the Fetcher.

[gone, 2015/03/19 19:01:35]

Done.

+
   // The content setting basically records a simplified subset of history.
   // For privacy reasons this needs to be cleared. The ClearHistoryForURLs
   // function removes any information from the banner content settings for the
@@ -82,17 +85,6 @@ class AppBannerSettingsHelper {
       const std::string& package_name_or_start_url,
       AppBannerEvent event);
 
-  // Checks if a URL is allowed to show a banner for the given package or start
-  // url.
-  static bool IsAllowed(content::WebContents* web_contents,
-                        const GURL& origin_url,
-                        const std::string& package_name_or_start_url);
-
-  // Blocks a URL from showing a banner for the given package or start url.
-  static void Block(content::WebContents* web_contents,
-                    const GURL& origin_url,
-                    const std::string& package_name_or_start_url);
-
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AppBannerSettingsHelper);
 };