[App banners] Be less strict about navigations

chrome/browser/banners/app_banner_settings_helper.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_BANNERS_APP_BANNER_SETTINGS_HELPER_H_
 #define CHROME_BROWSER_BANNERS_APP_BANNER_SETTINGS_HELPER_H_
 
 #include <set>
 #include <string>
 #include <vector>
@@ skipping 28 matching lines @@
 class AppBannerSettingsHelper {
  public:
   enum AppBannerEvent {
     APP_BANNER_EVENT_COULD_SHOW,
     APP_BANNER_EVENT_DID_SHOW,
     APP_BANNER_EVENT_DID_BLOCK,
     APP_BANNER_EVENT_DID_ADD_TO_HOMESCREEN,
     APP_BANNER_EVENT_NUM_EVENTS,
   };
 
+  // Returns whether or not the URLs match for everything except for the ref.
+  static bool URLsAreForTheSamePage(const GURL& first, const GURL& second);

[benwells, 2015/03/19 07:18:55]

Why is this is AppBannerSettingsHelper? Seems like it should go in
AppBannerManager or the Fetcher.

[gone, 2015/03/19 19:01:35]

Done.

+
   // The content setting basically records a simplified subset of history.
   // For privacy reasons this needs to be cleared. The ClearHistoryForURLs
   // function removes any information from the banner content settings for the
   // given URls.
   static void ClearHistoryForURLs(Profile* profile,
                                   const std::set<GURL>& origin_urls);
 
   static void RecordBannerEvent(content::WebContents* web_contents,
                                 const GURL& origin_url,
                                 const std::string& package_name_or_start_url,
@@ skipping 16 matching lines @@
 
   // Get the recorded event for an event type that only records the last event.
   // Should not be used with APP_BANNER_EVENT_COULD_SHOW. This is only exposed
   // for testing.
   static base::Time GetSingleBannerEvent(
       content::WebContents* web_contents,
       const GURL& origin_url,
       const std::string& package_name_or_start_url,
       AppBannerEvent event);
 
-  // Checks if a URL is allowed to show a banner for the given package or start
-  // url.
-  static bool IsAllowed(content::WebContents* web_contents,
-                        const GURL& origin_url,
-                        const std::string& package_name_or_start_url);
-
-  // Blocks a URL from showing a banner for the given package or start url.
-  static void Block(content::WebContents* web_contents,
-                    const GURL& origin_url,
-                    const std::string& package_name_or_start_url);
-
  private:
   DISALLOW_IMPLICIT_CONSTRUCTORS(AppBannerSettingsHelper);
 };
 
 #endif  // CHROME_BROWSER_BANNERS_APP_BANNER_SETTINGS_HELPER_H_