[MIPS] Upload a toolchain tarball for MIPS after the build step

[MIPS] Upload a toolchain tarball for MIPS after the build step

trusted toolchain tarball for MIPS nacl_sdk.tgz is now uploaded to Google
storage after it is built on linux-pnacl-x86_32-tests-mips.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=2275
TEST= none

Committed: http://src.chromium.org/viewvc/native_client?view=rev&revision=12533

[petarj, 2013-12-03 12:53:11]

Tested as a workaround at https://codereview.chromium.org/86033002/.

[petarj, 2013-12-07 00:57:46]

On 2013/12/03 12:53:11, petarj wrote:
> Tested as a workaround at https://codereview.chromium.org/86033002/.

Ping.

[petarj, 2013-12-10 22:54:43]

On 2013/12/07 00:57:46, petarj wrote:
> On 2013/12/03 12:53:11, petarj wrote:
> > Tested as a workaround at https://codereview.chromium.org/86033002/.
> 
> Ping.

Ping.

[Mark Seaborn, 2013-12-10 23:06:19]

https://codereview.chromium.org/101713002/diff/1/buildbot/buildbot_pnacl.sh
File buildbot/buildbot_pnacl.sh (right):

https://codereview.chromium.org/101713002/diff/1/buildbot/buildbot_pnacl.sh#n...
buildbot/buildbot_pnacl.sh:498: mode-buildbot-mips-toolchain() {
Putting this in buildbot_pnacl.sh is not ideal because this is not the PNaCl
toolchain you're building here.  Could you move this into a separate shell
script?

https://codereview.chromium.org/101713002/diff/1/buildbot/buildbot_pnacl.sh#n...
buildbot/buildbot_pnacl.sh:501: ${UP_DOWN_LOAD} UploadPnaclToolchains
${BUILDBOT_GOT_REVISION} \
What URL does this make the tarball available as?  I was trying to work that
out.  UploadPnaclToolchains suggests that "pnacl" might end up in the name,
although I don't think it does.

So maybe rename "UploadPnaclToolchains" to "UploadToolchainTarball"?

[petarj, 2013-12-11 19:08:59]

https://codereview.chromium.org/101713002/diff/1/buildbot/buildbot_pnacl.sh
File buildbot/buildbot_pnacl.sh (right):

https://codereview.chromium.org/101713002/diff/1/buildbot/buildbot_pnacl.sh#n...
buildbot/buildbot_pnacl.sh:498: mode-buildbot-mips-toolchain() {
On 2013/12/10 23:06:20, Mark Seaborn wrote:
> Putting this in buildbot_pnacl.sh is not ideal because this is not the PNaCl
> toolchain you're building here.  Could you move this into a separate shell
> script?

Done.

https://codereview.chromium.org/101713002/diff/1/buildbot/buildbot_pnacl.sh#n...
buildbot/buildbot_pnacl.sh:501: ${UP_DOWN_LOAD} UploadPnaclToolchains
${BUILDBOT_GOT_REVISION} \
On 2013/12/10 23:06:20, Mark Seaborn wrote:
> What URL does this make the tarball available as?  I was trying to work that
> out.  UploadPnaclToolchains suggests that "pnacl" might end up in the name,
> although I don't think it does.

The name will be naclsdk_linux_mips-trusted.tgz.
If I use Trybot, it will end up as:

http://gsdview.appspot.com/nativeclient-trybot/toolchain/12522/naclsdk_linux_...

Similar it should be for an archive.
> 
> So maybe rename "UploadPnaclToolchains" to "UploadToolchainTarball"?

Done.

[Mark Seaborn, 2013-12-11 20:42:05]

Don't leave TEST= empty please.  At least put "none" in it.  LGTM with changes
below.

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
File buildbot/buildbot_toolchain_mips_trusted.sh (right):

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
buildbot/buildbot_toolchain_mips_trusted.sh:7: if [[ $(pwd) != */native_client
]]; then
Nit: Put ""s around "*/native_client" to prevent globbing expansion

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
buildbot/buildbot_toolchain_mips_trusted.sh:20: UploadToolchainTarball() {
Rather than copying this function from file_up_down_load.sh, please call
UploadPnaclToolchains from that file but rename it (and all its uses) to
UploadToolchainTarball.

[petarj, 2013-12-11 22:18:40]

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
File buildbot/buildbot_toolchain_mips_trusted.sh (right):

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
buildbot/buildbot_toolchain_mips_trusted.sh:7: if [[ $(pwd) != */native_client
]]; then
On 2013/12/11 20:42:06, Mark Seaborn wrote:
> Nit: Put ""s around "*/native_client" to prevent globbing expansion

I have changed it to:
if [[ $(basename $(pwd)) != "native_client" ]]; then

Ok like that?

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
buildbot/buildbot_toolchain_mips_trusted.sh:20: UploadToolchainTarball() {
On 2013/12/11 20:42:06, Mark Seaborn wrote:
> Rather than copying this function from file_up_down_load.sh, please call
> UploadPnaclToolchains from that file but rename it (and all its uses) to
> UploadToolchainTarball.

Done.

[Mark Seaborn, 2013-12-11 22:34:52]

LGTM

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
File buildbot/buildbot_toolchain_mips_trusted.sh (right):

https://codereview.chromium.org/101713002/diff/30001/buildbot/buildbot_toolch...
buildbot/buildbot_toolchain_mips_trusted.sh:7: if [[ $(pwd) != */native_client
]]; then
On 2013/12/11 22:18:41, petarj wrote:
> On 2013/12/11 20:42:06, Mark Seaborn wrote:
> > Nit: Put ""s around "*/native_client" to prevent globbing expansion
> 
> I have changed it to:
> if [[ $(basename $(pwd)) != "native_client" ]]; then
> 
> Ok like that?

Yes, that's better.

[commit-bot: I haz the power, 2013-12-11 22:37:11]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/101713002/50001

[commit-bot: I haz the power, 2013-12-12 00:23:28]

Try job failure for 101713002-50001 (retry) on nacl-win8-64_newlib_dbg for steps
"annotate, small_tests under IRT, summary".
It's a second try, previously, steps "annotate, gyp_compile" failed.
http://build.chromium.org/p/tryserver.nacl/buildstatus?builder=nacl-win8-64_n...

[commit-bot: I haz the power, 2013-12-12 00:28:58]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/101713002/50001

[commit-bot: I haz the power, 2013-12-12 04:09:32]

Change committed as 12533