[MIPS] Upload a toolchain tarball for MIPS after the build step

buildbot/buildbot_toolchain_mips_trusted.sh

+#!/bin/bash
+# Copyright (c) 2013 The Native Client Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+# Script assumed to be run in native_client/
+if [[ $(pwd) != */native_client ]]; then

[Mark Seaborn, 2013/12/11 20:42:06]

Nit: Put ""s around "*/native_client" to prevent globbing expansion

[petarj, 2013/12/11 22:18:41]

I have changed it to:
if [[ $(basename $(pwd)) != "native_client" ]]; then

Ok like that?

[Mark Seaborn, 2013/12/11 22:34:52]

Yes, that's better.

+  echo "ERROR: must be run in native_client!"
+  exit 1
+fi
+
+set -x
+set -e
+set -u
+
+readonly UP_DOWN_LOAD="buildbot/file_up_down_load.sh"
+readonly TRUSTED_TOOLCHAIN_CREATOR=\
+"tools/trusted_cross_toolchains/trusted-toolchain-creator.mipsel.debian.sh"
+
+UploadToolchainTarball() {

[Mark Seaborn, 2013/12/11 20:42:06]

Rather than copying this function from file_up_down_load.sh, please call
UploadPnaclToolchains from that file but rename it (and all its uses) to
UploadToolchainTarball.

[petarj, 2013/12/11 22:18:41]

Done.

+  local rev=$1
+  local label=$2
+  local tarball=$3
+
+  ${UP_DOWN_LOAD} ComputeSha1 ${tarball} > ${tarball}.sha1hash
+  ${UP_DOWN_LOAD} UploadArchive \
+    toolchain/${rev}/naclsdk_${label}.tgz.sha1hash ${tarball}.sha1hash
+
+  ${UP_DOWN_LOAD} UploadArchive toolchain/${rev}/naclsdk_${label}.tgz ${tarball}
+}
+
+echo @@@BUILD_STEP compile_toolchain@@@
+${TRUSTED_TOOLCHAIN_CREATOR} nacl_sdk
+
+echo @@@BUILD_STEP upload_tarball@@@
+UploadToolchainTarball ${BUILDBOT_GOT_REVISION} linux_mips-trusted nacl_sdk.tgz