ServiceWorker: Add ServiceWorkerDispatcherTest

content/child/thread_safe_sender.h

Index: content/child/thread_safe_sender.h
diff --git a/content/child/thread_safe_sender.h b/content/child/thread_safe_sender.h
index 37ad96bfbf4ed8b16c1b13dd36f43fc546fa05fd..f42188b95da6438d44525b4997478714fec8d4d2 100644
--- a/content/child/thread_safe_sender.h
+++ b/content/child/thread_safe_sender.h
@@ -28,6 +28,10 @@ class CONTENT_EXPORT ThreadSafeSender
  public:
   bool Send(IPC::Message* msg) override;
 
+ protected:
+  ThreadSafeSender();  // for testing

[nasko, 2015/03/18 22:21:44]

nit: I'd put the comment above and expand it to explain that this is constructor
only used for testing and that is should *never* be used in actual shipping
code. Stronger language works better to discourage misuse : )

[nhiroki, 2015/03/18 23:14:37]

Agree. And it'd be far better that implementation disallows the usage. I moved
2-args private ctor to protected.

+  ~ThreadSafeSender() override;
+
  private:
   friend class ChildThreadImpl;  // for construction
   friend class IndexedDBDispatcherTest;
@@ -36,7 +40,6 @@ class CONTENT_EXPORT ThreadSafeSender
 
   ThreadSafeSender(const scoped_refptr<base::MessageLoopProxy>& main_loop,
                    const scoped_refptr<IPC::SyncMessageFilter>& sync_filter);
-  ~ThreadSafeSender() override;
 
   scoped_refptr<base::MessageLoopProxy> main_loop_;
   scoped_refptr<IPC::SyncMessageFilter> sync_filter_;