ServiceWorker: Add ServiceWorkerDispatcherTest

content/child/thread_safe_sender.h

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_CHILD_THREAD_SAFE_SENDER_H_
 #define CONTENT_CHILD_THREAD_SAFE_SENDER_H_
 
 #include "base/gtest_prod_util.h"
 #include "base/memory/ref_counted.h"
 #include "content/common/content_export.h"
@@ skipping 10 matching lines @@
 namespace content {
 class ChildThreadImpl;
 
 // The class of Sender returned by ChildThreadImpl::thread_safe_sender().
 class CONTENT_EXPORT ThreadSafeSender
     : public IPC::Sender,
       public base::RefCountedThreadSafe<ThreadSafeSender> {
  public:
   bool Send(IPC::Message* msg) override;
 
+ protected:
+  ThreadSafeSender();  // for testing

[nasko, 2015/03/18 22:21:44]

nit: I'd put the comment above and expand it to explain that this is constructor
only used for testing and that is should *never* be used in actual shipping
code. Stronger language works better to discourage misuse : )

[nhiroki, 2015/03/18 23:14:37]

Agree. And it'd be far better that implementation disallows the usage. I moved
2-args private ctor to protected.

+  ~ThreadSafeSender() override;
+
  private:
   friend class ChildThreadImpl;  // for construction
   friend class IndexedDBDispatcherTest;
   friend class WebIDBCursorImplTest;
   friend class base::RefCountedThreadSafe<ThreadSafeSender>;
 
   ThreadSafeSender(const scoped_refptr<base::MessageLoopProxy>& main_loop,
                    const scoped_refptr<IPC::SyncMessageFilter>& sync_filter);
-  ~ThreadSafeSender() override;
 
   scoped_refptr<base::MessageLoopProxy> main_loop_;
   scoped_refptr<IPC::SyncMessageFilter> sync_filter_;
 
   DISALLOW_COPY_AND_ASSIGN(ThreadSafeSender);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_CHILD_THREAD_SAFE_SENDER_H_