Issue 1016933002: Revert of Call RegisterCrashKeys for chrome.exe in static build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1016933002: Revert of Call RegisterCrashKeys for chrome.exe in static build. (Closed)

Created:
5 years, 9 months ago by erikwright (departed)

Modified:
5 years, 9 months ago

Reviewers:
Robert Sesek, Ken Russell (switch to Gerrit), grt (UTC plus 2)

CC:
chromium-reviews, kalyank, sadrul, Sigurður Ásgeirsson, robertshield, chrisha, Ken Russell (switch to Gerrit), cpu_(ooo_6.6-7.5), scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of Call RegisterCrashKeys for chrome.exe in static build. (patchset #5 id:140001 of https://codereview.chromium.org/1008523002/) Reason for revert: Test failures. Original issue's description: > Call RegisterCrashKeys for chrome.exe in static build. > > In component builds the single invocation from child_process_logging_win is sufficient (as there is only a single copy of base). > > BUG=460512 > > Committed: https://crrev.com/0bfeabec41ac37bc9e8c0b62316a11269db156e5 > Cr-Commit-Position: refs/heads/master@{#320967} TBR=rsesek@chromium.org,grt@chromium.org,kbr@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=460512 Committed: https://crrev.com/d48deccb1d0347b9adb5fb3a579d2afef138ff6b Cr-Commit-Position: refs/heads/master@{#320994}

Created: 5 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -18 lines)			Patch
	M	chrome/app/chrome_crash_reporter_client.cc	View		1 chunk	+3 lines, -10 lines	0 comments	Download
	M	components/crash/app/breakpad_win.cc	View		1 chunk	+0 lines, -8 lines	0 comments	Download

Total messages: 4 (0 generated)

erikwright (departed)

Created Revert of Call RegisterCrashKeys for chrome.exe in static build.

5 years, 9 months ago (2015-03-17 22:21:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016933002/1

5 years, 9 months ago (2015-03-17 22:21:50 UTC) #2

commit-bot: I haz the power

5 years, 9 months ago (2015-03-17 22:23:45 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/d48deccb1d0347b9adb5fb3a579d2afef138ff6b
Cr-Commit-Position: refs/heads/master@{#320994}