Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Unified Diff: components/crash/app/breakpad_win.cc

Issue 1016933002: Revert of Call RegisterCrashKeys for chrome.exe in static build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/crash/app/breakpad_win.cc
diff --git a/components/crash/app/breakpad_win.cc b/components/crash/app/breakpad_win.cc
index 71a965f78e2815869ece3a989f1c918ce7a9c3b0..38020f447dc1341041bb3cce0d77907b49a389c9 100644
--- a/components/crash/app/breakpad_win.cc
+++ b/components/crash/app/breakpad_win.cc
@@ -541,16 +541,8 @@
base::CommandLine::ForCurrentProcess(),
GetCrashReporterClient());
-#if !defined(COMPONENT_BUILD)
- // chrome/common/child_process_logging_win.cc registers crash keys for
- // chrome.dll. In a component build, that is sufficient as chrome.dll and
- // chrome.exe share a copy of base (in base.dll).
- // In a static build, the EXE must separately initialize the crash keys
- // configuration as it has its own statically linked copy of base.
base::debug::SetCrashKeyReportingFunctions(&SetCrashKeyValueForBaseDebug,
&ClearCrashKeyForBaseDebug);
- GetCrashReporterClient()->RegisterCrashKeys();
-#endif
google_breakpad::ExceptionHandler::MinidumpCallback callback = NULL;
LPTOP_LEVEL_EXCEPTION_FILTER default_filter = NULL;
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698