Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: BUILD.gn

Issue 1016923002: Fix the GN build for MIPS. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 509d78afea11a1e700d3fa040092a98c14fa7b68..56fe5179f076a43c794aa5c310a791610f31bdd2 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -33,7 +33,8 @@ v8_toolset_for_d8 = "host"
# x64 Linux host. Eventually we need to support all of the host/target
# configurations v8 runs on.
if (host_cpu == "x64" && host_os == "linux" &&
- (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86")) {
+ (target_cpu == "arm" || target_cpu == "mipsel" ||
+ target_cpu == "mips64el" || target_cpu == "x86")) {
Dirk Pranke 2015/03/17 21:32:04 As discussed over chat, I don't think you want thi
wtc 2015/03/17 21:42:05 Done.
snapshot_toolchain = "//build/toolchain/linux:clang_x86"
} else {
snapshot_toolchain = default_toolchain
@@ -113,7 +114,7 @@ config("toolchain") {
defines = []
cflags = []
- # TODO(jochen): Add support for arm subarchs, mips, mipsel.
+ # TODO(jochen): Add support for arm subarchs, mips, mipsel, mips64el.
wtc 2015/03/17 21:42:05 Jochen, Michael: does it make sense to add "mips64
if (v8_target_arch == "arm") {
defines += [ "V8_TARGET_ARCH_ARM" ]
@@ -150,6 +151,12 @@ config("toolchain") {
if (v8_target_arch == "arm64") {
defines += [ "V8_TARGET_ARCH_ARM64" ]
}
+ if (v8_target_arch == "mipsel") {
+ defines += [ "V8_TARGET_ARCH_MIPS" ]
+ }
+ if (v8_target_arch == "mips64el") {
+ defines += [ "V8_TARGET_ARCH_MIPS64" ]
+ }
if (v8_target_arch == "x86") {
defines += [ "V8_TARGET_ARCH_IA32" ]
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698