Fix the GN build for MIPS.

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/android/config.gni")
 import("//build/config/arm.gni")
 import("//build/config/mips.gni")
 
 # Because standalone V8 builds are not supported, assume this is part of a
 # Chromium build.
@@ skipping 15 matching lines @@
 v8_random_seed = "314159265"
 v8_toolset_for_d8 = "host"
 
 # The snapshot needs to be compiled for the host, but compiled with
 # a toolchain that matches the bit-width of the target.
 #
 # TODO(GYP): For now we only support 32-bit little-endian target builds from an
 # x64 Linux host. Eventually we need to support all of the host/target
 # configurations v8 runs on.
 if (host_cpu == "x64" && host_os == "linux" &&
-    (target_cpu == "arm" || target_cpu == "mipsel" || target_cpu == "x86")) {
+    (target_cpu == "arm" || target_cpu == "mipsel" ||
+     target_cpu == "mips64el" || target_cpu == "x86")) {

[Dirk Pranke, 2015/03/17 21:32:04]

As discussed over chat, I don't think you want this particular change (it would
build the snapshot using 32-bit pointers, and we need to use 64-bit pointers for
mips64el).

[wtc, 2015/03/17 21:42:05]

Done.

   snapshot_toolchain = "//build/toolchain/linux:clang_x86"
 } else {
   snapshot_toolchain = default_toolchain
 }
 
 ###############################################################################
 # Configurations
 #
 config("internal_config") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
@@ skipping 59 matching lines @@
     defines += [ "V8_USE_EXTERNAL_STARTUP_DATA" ]
   }
 }
 
 config("toolchain") {
   visibility = [ ":*" ]  # Only targets in this file can depend on this.
 
   defines = []
   cflags = []
 
-  # TODO(jochen): Add support for arm subarchs, mips, mipsel.
+  # TODO(jochen): Add support for arm subarchs, mips, mipsel, mips64el.

[wtc, 2015/03/17 21:42:05]

Jochen, Michael: does it make sense to add "mips64el" to this TODO comment, or
should I revert this change as well?

 
   if (v8_target_arch == "arm") {
     defines += [ "V8_TARGET_ARCH_ARM" ]
     if (current_cpu == "arm") {
       if (arm_version == 7) {
         defines += [ "CAN_USE_ARMV7_INSTRUCTIONS" ]
       }
       if (arm_fpu == "vfpv3-d16") {
         defines += [ "CAN_USE_VFP3_INSTRUCTIONS" ]
       } else if (arm_fpu == "vfpv3") {
@@ skipping 16 matching lines @@
         "CAN_USE_VFP32DREGS",
         "USE_EABI_HARDFLOAT=0",
       ]
     }
 
     # TODO(jochen): Add support for arm_test_noprobe.
   }
   if (v8_target_arch == "arm64") {
     defines += [ "V8_TARGET_ARCH_ARM64" ]
   }
+  if (v8_target_arch == "mipsel") {
+    defines += [ "V8_TARGET_ARCH_MIPS" ]
+  }
+  if (v8_target_arch == "mips64el") {
+    defines += [ "V8_TARGET_ARCH_MIPS64" ]
+  }
   if (v8_target_arch == "x86") {
     defines += [ "V8_TARGET_ARCH_IA32" ]
   }
   if (v8_target_arch == "x64") {

[wtc, 2015/03/17 21:16:01]

Would you like me to change these to else if's?

     defines += [ "V8_TARGET_ARCH_X64" ]
   }
   if (is_win) {
     defines += [ "WIN32" ]
     # TODO(jochen): Support v8_enable_prof.
   }
 
   # TODO(jochen): Add support for compiling with simulators.
 
   if (is_debug) {
@@ skipping 1417 matching lines @@
       sources += [
         "src/d8-debug.cc",
         "$target_gen_dir/d8-js.cc",
       ]
     }
     if (v8_enable_i18n_support) {
       deps += [ "//third_party/icu" ]
     }
   }
 }