Fix the GN build for MIPS.

Fix the GN build for MIPS.

Define V8_TARGET_ARCH_MIPS or V8_TARGET_ARCH_MIPS64 if the target
arch is mipsel or mips64el.

R=dpranke@chromium.org,jochen@chromium.org,machenbach@chromium.org
BUG=v8:3972
LOG=N

Committed: https://crrev.com/97104255299e9f547eb2ec7d8523729acf9c3e8d
Cr-Commit-Position: refs/heads/master@{#27249}

[wtc, 2015-03-17 21:16:01]

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode163
BUILD.gn:163: if (v8_target_arch == "x64") {

Would you like me to change these to else if's?

[wtc, 2015-03-17 21:24:13]

Please also advise whether this CL should use LOG=Y or LOG=N. Thanks.

[Michael Achenbach, 2015-03-17 21:24:47]

lgtm (rubber-stamp)

[Michael Achenbach, 2015-03-17 21:25:46]

Should use log=n

[Dirk Pranke, 2015-03-17 21:32:04]

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode37
BUILD.gn:37: target_cpu == "mips64el" || target_cpu == "x86")) {
As discussed over chat, I don't think you want this particular change (it would
build the snapshot using 32-bit pointers, and we need to use 64-bit pointers for
mips64el).

[wtc, 2015-03-17 21:42:05]

I uploaded patch set 2.

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode37
BUILD.gn:37: target_cpu == "mips64el" || target_cpu == "x86")) {
On 2015/03/17 21:32:04, Dirk Pranke wrote:
> As discussed over chat, I don't think you want this particular change (it
would
> build the snapshot using 32-bit pointers, and we need to use 64-bit pointers
for
> mips64el).

Done.

https://codereview.chromium.org/1016923002/diff/1/BUILD.gn#newcode117
BUILD.gn:117: # TODO(jochen): Add support for arm subarchs, mips, mipsel,
mips64el.

Jochen, Michael: does it make sense to add "mips64el" to this TODO comment, or
should I revert this change as well?

[Dirk Pranke, 2015-03-17 21:44:13]

lgtm

https://codereview.chromium.org/1016923002/diff/20001/BUILD.gn
File BUILD.gn (right):

https://codereview.chromium.org/1016923002/diff/20001/BUILD.gn#newcode116
BUILD.gn:116: # TODO(jochen): Add support for arm subarchs, mips, mipsel,
mips64el.
I think this is completely appropriate. 

lgtm.

[wtc, 2015-03-17 22:38:47]

The CQ bit was checked by wtc@chromium.org

[wtc, 2015-03-17 22:38:47]

The patchset sent to the CQ was uploaded after l-g-t-m from
machenbach@chromium.org
Link to the patchset: https://codereview.chromium.org/1016923002/#ps20001
(title: "Revert the snapshot_toolchain change for mips64el.")

[commit-bot: I haz the power, 2015-03-17 22:39:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1016923002/20001

[commit-bot: I haz the power, 2015-03-17 23:13:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-17 23:13:15]

Patchset 2 (id:??) landed as
https://crrev.com/97104255299e9f547eb2ec7d8523729acf9c3e8d
Cr-Commit-Position: refs/heads/master@{#27249}