Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1016913002: pkg/smoke: support latest analyzer version and formatted code (Closed)

Created:
5 years, 9 months ago by kevmoo
Modified:
5 years, 9 months ago
Reviewers:
jakemac
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/smoke@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

support latest analyzer version and formatted code Also prep for release 0.3.1+1 R=jakemac@google.com Committed: https://github.com/dart-lang/smoke/commit/2f5d697d4611515ed6688676ce259f158a791f58

Patch Set 1 #

Total comments: 1

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+864 lines, -938 lines) Patch
M CHANGELOG.md View 1 chunk +3 lines, -0 lines 0 comments Download
M lib/codegen/generator.dart View 19 chunks +62 lines, -50 lines 0 comments Download
M lib/codegen/recorder.dart View 13 chunks +40 lines, -36 lines 0 comments Download
M lib/mirrors.dart View 7 chunks +22 lines, -23 lines 0 comments Download
M lib/smoke.dart View 6 chunks +29 lines, -35 lines 0 comments Download
M lib/src/default_transformer.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/src/implementation.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M lib/static.dart View 4 chunks +9 lines, -11 lines 0 comments Download
M lib/static_debug.dart View 3 chunks +47 lines, -49 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M test/codegen/common.dart View 1 chunk +6 lines, -3 lines 0 comments Download
M test/codegen/end_to_end_test.dart View 1 7 chunks +36 lines, -23 lines 0 comments Download
M test/codegen/generator_test.dart View 10 chunks +77 lines, -83 lines 0 comments Download
M test/codegen/recorder_test.dart View 15 chunks +384 lines, -476 lines 0 comments Download
M test/codegen/testing_resolver_utils.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M test/common.dart View 5 chunks +40 lines, -24 lines 0 comments Download
M test/common_utils_test.dart View 1 chunk +9 lines, -6 lines 0 comments Download
M test/mirrors_used_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M test/piece1.dart View 1 chunk +10 lines, -19 lines 0 comments Download
M test/piece2.dart View 1 chunk +16 lines, -24 lines 0 comments Download
M test/static_in_pieces_test.dart View 1 chunk +60 lines, -57 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
kevmoo
5 years, 9 months ago (2015-03-17 20:56:56 UTC) #2
jakemac
https://codereview.chromium.org/1016913002/diff/1/pubspec.yaml File pubspec.yaml (right): https://codereview.chromium.org/1016913002/diff/1/pubspec.yaml#newcode2 pubspec.yaml:2: version: 0.3.1+1 what was up with the -dev before? ...
5 years, 9 months ago (2015-03-17 21:04:08 UTC) #3
kevmoo
On 2015/03/17 21:04:08, jakemac wrote: > https://codereview.chromium.org/1016913002/diff/1/pubspec.yaml > File pubspec.yaml (right): > > https://codereview.chromium.org/1016913002/diff/1/pubspec.yaml#newcode2 > ...
5 years, 9 months ago (2015-03-17 23:49:15 UTC) #4
jakemac
On 2015/03/17 23:49:15, kevmoo wrote: > On 2015/03/17 21:04:08, jakemac wrote: > > https://codereview.chromium.org/1016913002/diff/1/pubspec.yaml > ...
5 years, 9 months ago (2015-03-18 15:05:39 UTC) #5
jakemac
lgtm
5 years, 9 months ago (2015-03-18 15:05:45 UTC) #6
kevmoo
5 years, 9 months ago (2015-03-18 15:39:11 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
2f5d697d4611515ed6688676ce259f158a791f58 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698