Implement the ServiceWorkerRegistration.getNotifications() API.

Source/modules/notifications/ServiceWorkerRegistrationNotifications.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "modules/notifications/ServiceWorkerRegistrationNotifications.h"
 
 #include "bindings/core/v8/CallbackPromiseAdapter.h"
 #include "bindings/core/v8/ExceptionState.h"
 #include "bindings/core/v8/ScriptPromiseResolver.h"
 #include "bindings/core/v8/SerializedScriptValue.h"
 #include "bindings/core/v8/SerializedScriptValueFactory.h"
 #include "bindings/core/v8/V8ThrowException.h"
 #include "core/dom/DOMException.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/ExecutionContext.h"
+#include "modules/notifications/GetNotificationOptions.h"
 #include "modules/notifications/Notification.h"
 #include "modules/notifications/NotificationOptions.h"
 #include "platform/weborigin/KURL.h"
 #include "public/platform/Platform.h"
 #include "public/platform/WebSerializedOrigin.h"
 #include "public/platform/modules/notifications/WebNotificationData.h"
 #include "public/platform/modules/notifications/WebNotificationManager.h"
 
 namespace blink {
+namespace {
+
+// Allows using a CallbackPromiseAdapter with a WebVector to resolve the
+// getNotifications() promise with a HeapVector owning Notifications.
+class NotificationArray {
+public:
+    using WebType = WebVector<WebPersistentNotificationInfo>;
+
+    static HeapVector<Member<Notification>> take(ScriptPromiseResolver* resolver, WebType* notificationInfosRaw)
+    {
+        OwnPtr<WebType> notificationInfos = adoptPtr(notificationInfosRaw);
+        HeapVector<Member<Notification>> notifications;
+
+        for (size_t i = 0; i < notificationInfos->size(); ++i) {
+            const WebPersistentNotificationInfo& notificationInfo = (*notificationInfos)[i];

[johnme, 2015/03/17 19:39:35]

Nit - how about:

for (const WebPersistentNotificationInfo& notificationInfo : *notificationInfos)

You'll have to wait for https://codereview.chromium.org/1014933002 to land first
though!

[Peter Beverloo, 2015/03/19 15:43:07]

I waited and applied it :-). Thanks!

+            notifications.append(Notification::create(resolver->executionContext(), notificationInfo.persistentNotificationId, notificationInfo.data));
+        }
+
+        return notifications;
+    }
+
+    static void dispose(WebType* notificationInfosRaw)
+    {
+        delete notificationInfosRaw;

[haraken, 2015/03/18 01:32:54]

I don't fully understand why we need to take a raw pointer and explicitly call
delete. It would be better if we can delegate the work to the normal OwnPtr
mechanism.

[Peter Beverloo, 2015/03/19 15:43:07]

In some cases the CallbackPromiseAdapter is used to pass a boolean, in which
case the memory exists on-stack by the caller (the embedder). The dispose()
method will be empty for those cases.

In this case, Blink takes ownership the data passed in to the callback, here
|notificationInfosRaw|. This is a more common paradigm for
CallbackPromiseAdapter.

+    }
+
+private:
+    NotificationArray() = delete;
+};
+
+} // namespace
 
 ScriptPromise ServiceWorkerRegistrationNotifications::showNotification(ScriptState* scriptState, ServiceWorkerRegistration& serviceWorkerRegistration, const String& title, const NotificationOptions& options, ExceptionState& exceptionState)
 {
     ExecutionContext* executionContext = scriptState->executionContext();
 
     // If context object's active worker is null, reject promise with a TypeError exception.
     if (!serviceWorkerRegistration.active())
         return ScriptPromise::reject(scriptState, V8ThrowException::createTypeError(scriptState->isolate(), "No active registration available on the ServiceWorkerRegistration."));
 
     // If permission for notification's origin is not "granted", reject promise with a TypeError exception, and terminate these substeps.
@@ skipping 28 matching lines @@
     SecurityOrigin* origin = executionContext->securityOrigin();
     ASSERT(origin);
 
     WebNotificationManager* notificationManager = Platform::current()->notificationManager();
     ASSERT(notificationManager);
 
     notificationManager->showPersistent(WebSerializedOrigin(*origin), notification, serviceWorkerRegistration.webRegistration(), callbacks);
     return promise;
 }
 
+ScriptPromise ServiceWorkerRegistrationNotifications::getNotifications(ScriptState* scriptState, ServiceWorkerRegistration& serviceWorkerRegistration, const GetNotificationOptions& options)
+{
+    RefPtrWillBeRawPtr<ScriptPromiseResolver> resolver = ScriptPromiseResolver::create(scriptState);
+    ScriptPromise promise = resolver->promise();
+
+    SecurityOrigin* origin = scriptState->executionContext()->securityOrigin();
+    ASSERT(origin);
+
+    WebNotificationGetCallbacks* callbacks = new CallbackPromiseAdapter<NotificationArray, void>(resolver);
+
+    WebNotificationManager* notificationManager = Platform::current()->notificationManager();
+    ASSERT(notificationManager);
+
+    notificationManager->getNotifications(options.tag(), serviceWorkerRegistration.webRegistration(), callbacks);
+    return promise;
+}
+
 } // namespace blink