Add begin()/end() to WebVector to enable range-based for loops

Add begin()/end() to WebVector to enable range-based for loops

BUG=468029
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192170

[johnme, 2015-03-17 19:36:25]

johnme@chromium.org changed reviewers:
+ mkwst@chromium.org

[Mike West, 2015-03-17 19:54:14]

LGTM % tests.

It might be reasonable to add a WebVectorTest.cpp file here, such that we can
start testing that the methods we're adding actually work. Adding some trivial
unittests here would be helpful for the future.

[johnme, 2015-03-18 19:35:50]

On 2015/03/17 19:54:14, Mike West wrote:
> It might be reasonable to add a WebVectorTest.cpp file here, such that we can
> start testing that the methods we're adding actually work. Adding some trivial
> unittests here would be helpful for the future.

Done

[Peter Beverloo, 2015-03-19 12:03:19]

peter@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2015-03-19 12:03:19]

The test should be in Source/platform/.

https://codereview.chromium.org/1014933002/diff/20001/Source/web/WebVectorTes...
File Source/web/WebVectorTest.cpp (right):

https://codereview.chromium.org/1014933002/diff/20001/Source/web/WebVectorTes...
Source/web/WebVectorTest.cpp:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
nit: 2015

https://codereview.chromium.org/1014933002/diff/20001/Source/web/WebVectorTes...
Source/web/WebVectorTest.cpp:9: #include <gtest/gtest.h>
nit: no blank line on line 7, add one between 8 and 9.

[Mike West, 2015-03-19 12:35:10]

What peter@ said. Otherwise, brilliant!

[johnme, 2015-03-19 12:47:24]

Addressed Peter's review comments - thanks :)

> The test should be in Source/platform/.

Done

https://codereview.chromium.org/1014933002/diff/20001/Source/web/WebVectorTes...
File Source/web/WebVectorTest.cpp (right):

https://codereview.chromium.org/1014933002/diff/20001/Source/web/WebVectorTes...
Source/web/WebVectorTest.cpp:1: // Copyright 2014 The Chromium Authors. All
rights reserved.
On 2015/03/19 12:03:19, Peter Beverloo wrote:
> nit: 2015

Done.

https://codereview.chromium.org/1014933002/diff/20001/Source/web/WebVectorTes...
Source/web/WebVectorTest.cpp:9: #include <gtest/gtest.h>
On 2015/03/19 12:03:19, Peter Beverloo wrote:
> nit: no blank line on line 7, add one between 8 and 9.

Disagree - other tests I've looked at (WebNodeTest, WebViewTest, WebFrameTest,
DecimalTest, SharedBufferTest) all follow this convention, and it matches the
examples in http://www.chromium.org/blink/coding-style#TOC-include-Statements

[johnme, 2015-03-19 12:47:28]

The CQ bit was checked by johnme@chromium.org

[johnme, 2015-03-19 12:47:29]

The patchset sent to the CQ was uploaded after l-g-t-m from mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/1014933002/#ps40001
(title: "Move test to Source/platform/")

[commit-bot: I haz the power, 2015-03-19 12:48:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1014933002/40001

[commit-bot: I haz the power, 2015-03-19 14:26:03]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192170

[Peter Beverloo, 2015-03-20 12:10:20]

On 2015/03/19 14:26:03, I haz the power (commit-bot) wrote:
> Committed patchset #3 (id:40001) as
> https://src.chromium.org/viewvc/blink?view=rev&revision=192170

Post-land lgtm! Thanks for adding this :-)