Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 1016823003: Revert "Fix a problem that JP2 image is not displayed because index color space is used" (Closed)

Created:
5 years, 9 months ago by Tom Sepez
Modified:
5 years, 9 months ago
Reviewers:
jun_fang
CC:
kai_jing, Lei Zhang
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Fix a problem that JP2 image is not displayed because index color space is used" This reverts commit 5a0e504d53195892458d819e52c62bea0c710bd5. Original review URL https://codereview.chromium.org/1009513003 Reason for revert: New "corpus" tests show that this is no longer rendering some images. See, e.g. http://chromegw/i/client.pdfium/builders/linux/builds/144/steps/corpus%20tests/logs/stdio for those that diff'd. TBR=jun_fang@foxitsoftware.com Committed: https://pdfium.googlesource.com/pdfium/+/a4161734ee7f2b64cbe3431385a4b4c9a426ca47

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -26 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp View 3 chunks +11 lines, -20 lines 0 comments Download
M core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp View 1 chunk +2 lines, -6 lines 1 comment Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Sorry, looks like the new code isn't working right. Note that you will have to ...
5 years, 9 months ago (2015-03-17 18:48:17 UTC) #2
Tom Sepez
Committed patchset #1 (id:1) manually as a4161734ee7f2b64cbe3431385a4b4c9a426ca47 (presubmit successful).
5 years, 9 months ago (2015-03-17 18:48:27 UTC) #3
jun_fang
On 2015/03/17 18:48:27, Tom Sepez wrote: > Committed patchset #1 (id:1) manually as > a4161734ee7f2b64cbe3431385a4b4c9a426ca47 ...
5 years, 9 months ago (2015-03-17 18:54:24 UTC) #4
jun_fang
5 years, 9 months ago (2015-03-17 18:58:32 UTC) #5
Message was sent while issue was closed.
https://codereview.chromium.org/1016823003/diff/1/core/src/fpdfapi/fpdf_rende...
File core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp (left):

https://codereview.chromium.org/1016823003/diff/1/core/src/fpdfapi/fpdf_rende...
core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp:508: FX_DWORD arrSize =
pDecode ? pDecode->GetCount() : 0;
line 508 to line 511 should be moved to line 513.

Powered by Google App Engine
This is Rietveld 408576698