Fix a problem that JP2 image is not displayed because index color space is used

Fix a problem that JP2 image is not displayed because index color space is used

There are two issues in this bug.

One is that JP2 image is not displayed because it aborts loading Jpx bitmap when the number of components in color space is different with that one in JPX images. I found that the number of components in color space isn't updated after it's initialized. For index color space, the component shall inherit from its base color space.

The second issue is that displayed color is not correct after I fixed the first issue. The root cause is that sRGB is used in JPX image, it doesn't need to map from index to RGB again.

BUG=464215
R=tsepez@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/5a0e504d53195892458d819e52c62bea0c710bd5

[jun_fang, 2015-03-15 07:04:14]

jun_fang@foxitsoftware.com changed reviewers:
+ kai_jing@foxitsoftware.com, thestig@chromium.org, tsepez@chromium.org

[jun_fang, 2015-03-15 07:04:15]

Hi Tom,

Please review it.

[Tom Sepez, 2015-03-16 17:03:08]

On 2015/03/15 07:04:15, jun_fang wrote:
> Hi Tom,
> 
> Please review it.

Can I get a description of what's wrong in the CL plus a test case?

[Tom Sepez, 2015-03-16 17:07:59]

See comment + nit, Otherwise LGTM

https://codereview.chromium.org/1009513003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right):

https://codereview.chromium.org/1009513003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:844: comps[i] = *(pBuf + i) /
255;
nit: pbuf[i]

[jun_fang, 2015-03-16 19:07:13]

On 2015/03/16 17:07:59, Tom Sepez wrote:
> See comment + nit, Otherwise LGTM
> 
>
https://codereview.chromium.org/1009513003/diff/1/core/src/fpdfapi/fpdf_page/...
> File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right):
> 
>
https://codereview.chromium.org/1009513003/diff/1/core/src/fpdfapi/fpdf_page/...
> core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:844: comps[i] = *(pBuf + i) /
> 255;
> nit: pbuf[i]

I will provide unit tests for this CL after it's landed.

[jun_fang, 2015-03-16 19:07:39]

https://codereview.chromium.org/1009513003/diff/1/core/src/fpdfapi/fpdf_page/...
File core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp (right):

https://codereview.chromium.org/1009513003/diff/1/core/src/fpdfapi/fpdf_page/...
core/src/fpdfapi/fpdf_page/fpdf_page_colors.cpp:844: comps[i] = *(pBuf + i) /
255;
On 2015/03/16 17:07:59, Tom Sepez wrote:
> nit: pbuf[i]

Acknowledged.

[jun_fang, 2015-03-16 19:10:15]

Committed patchset #2 (id:20001) manually as
5a0e504d53195892458d819e52c62bea0c710bd5 (presubmit successful).