[Webapp Refactor] Reparent the ConnectedView into the delegate.

[Webapp Refactor] Reparent the ConnectedView into the delegate.

In the existing implementation, the session connector creates the
DesktopConnectedView for both app remoting and desktop remoting and
assigns it to a global.

This CL removes the global, |remoting.desktopConnectedView|, and makes
it owned by the corresponding application delegate.

This will enable us to create an app remoting specific delegate in the
upcoming CL.

BUG=465878
Committed: https://crrev.com/d267b3623a7737bfbed88dde8277d7ff6167bb80
Cr-Commit-Position: refs/heads/master@{#321229}

[kelvinp, 2015-03-17 01:02:02]

kelvinp@chromium.org changed reviewers:
+ jamiewalch@chromium.org

[kelvinp, 2015-03-17 01:03:45]

Patchset #1 (id:1) has been deleted

[kelvinp, 2015-03-17 01:06:17]

PTAL

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/client_session.js (left):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:453:
remoting.desktopConnectedView.onConnectionReady(ready);
Implemented in DesktopConnectedView as an event instead.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:478: if (this.hasCapability(
Moved to DesktopConnectedView.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/client_session.js:620:
remoting.ClientSession.prototype.enableDebugRegion = function(enable) {
Moved to ConnectedView.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/connected_view.js (right):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/connected_view.js:135:
remoting.ConnectedView.prototype.handleDebugRegion = function(region) {
Moved from DesktopConnectedView.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/connected_view.js:158:
remoting.ConnectedView.prototype.enableDebugRegion = function(enable) {
Moved from ClientSession.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_connected_view.js (left):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_connected_view.js:404:
remoting.DesktopConnectedView.prototype.handleDebugRegion = function(region) {
Moved to ConnectedView.

[Jamie, 2015-03-18 01:03:56]

https://codereview.chromium.org/1016623002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_remoting.js (right):

https://codereview.chromium.org/1016623002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_remoting.js:307: remoting.accessCode = '';
Did you intend to remove this?

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/app_rem...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/app_rem...
remoting/webapp/app_remoting/js/app_remoting.js:249: // TODO(kelvinp): Moves all
app remoting specific logic into
s/Moves/Move/

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_viewport.js (right):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_viewport.js:65: // desktop size.  Moves this to
remoting.AppConnectedView later.
s/Moves/Move/

[kelvinp, 2015-03-18 18:44:22]

PTAL

https://codereview.chromium.org/1016623002/diff/20001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_remoting.js (right):

https://codereview.chromium.org/1016623002/diff/20001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_remoting.js:307: remoting.accessCode = '';
On 2015/03/18 01:03:56, Jamie wrote:
> Did you intend to remove this?

Yes, it is not being used any where.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/app_rem...
File remoting/webapp/app_remoting/js/app_remoting.js (right):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/app_rem...
remoting/webapp/app_remoting/js/app_remoting.js:249: // TODO(kelvinp): Moves all
app remoting specific logic into
On 2015/03/18 01:03:56, Jamie wrote:
> s/Moves/Move/

Done.

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
File remoting/webapp/crd/js/desktop_viewport.js (right):

https://codereview.chromium.org/1016623002/diff/40001/remoting/webapp/crd/js/...
remoting/webapp/crd/js/desktop_viewport.js:65: // desktop size.  Moves this to
remoting.AppConnectedView later.
On 2015/03/18 01:03:56, Jamie wrote:
> s/Moves/Move/

Done.

[kelvinp, 2015-03-18 19:13:56]

Rebased onto master.

PTAL

[Jamie, 2015-03-18 20:01:36]

lgtm

[kelvinp, 2015-03-18 20:05:29]

The CQ bit was checked by kelvinp@chromium.org

[commit-bot: I haz the power, 2015-03-18 20:05:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1016623002/80001

[commit-bot: I haz the power, 2015-03-18 23:08:23]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2015-03-18 23:09:15]

Patchset 4 (id:??) landed as
https://crrev.com/d267b3623a7737bfbed88dde8277d7ff6167bb80
Cr-Commit-Position: refs/heads/master@{#321229}