Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: remoting/webapp/crd/js/session_connector_impl.js

Issue 1016623002: [Webapp Refactor] Reparent the ConnectedView into the delegate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebasing Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « remoting/webapp/crd/js/remoting.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/webapp/crd/js/session_connector_impl.js
diff --git a/remoting/webapp/crd/js/session_connector_impl.js b/remoting/webapp/crd/js/session_connector_impl.js
index 13def395a28b4a4cc4633f4fe91f07671d0d7d90..62e2daede06d5393789b6856e20be60c3300e16e 100644
--- a/remoting/webapp/crd/js/session_connector_impl.js
+++ b/remoting/webapp/crd/js/session_connector_impl.js
@@ -20,13 +20,6 @@ var remoting = remoting || {};
remoting.clientSession = null;
/**
- * @type {remoting.DesktopConnectedView} The client session view object, set
- * once the connector has invoked its onOk callback.
- * TODO(garykac): Have this owned by someone instead of being global.
- */
-remoting.desktopConnectedView = null;
-
-/**
* @param {HTMLElement} clientContainer Container element for the client view.
* @param {function(remoting.ConnectionInfo):void} onConnected Callback on
* success.
@@ -100,9 +93,6 @@ remoting.SessionConnectorImpl.prototype.resetConnection_ = function() {
/** @private {remoting.ClientSession} */
this.clientSession_ = null;
- /** @private {remoting.DesktopConnectedView} */
- this.connectedView_ = null;
-
/** @private {XMLHttpRequest} */
this.pendingXhr_ = null;
@@ -361,11 +351,6 @@ remoting.SessionConnectorImpl.prototype.onPluginInitialized_ = function(
this.onProtocolExtensionMessage_.bind(this));
remoting.clientSession = this.clientSession_;
- this.connectedView_ = new remoting.DesktopConnectedView(
- this.plugin_, this.clientContainer_, this.host_,
- this.connectionMode_, this.defaultRemapKeys_);
- remoting.desktopConnectedView = this.connectedView_;
-
this.clientSession_.logHostOfflineErrors(this.logHostOfflineErrors_);
this.clientSession_.addEventListener(
remoting.ClientSession.Events.stateChanged,
@@ -393,10 +378,6 @@ remoting.SessionConnectorImpl.prototype.removePlugin_ = function() {
this.clientSession_ = null;
remoting.clientSession = null;
- base.dispose(this.connectedView_);
- this.connectedView_ = null;
- remoting.desktopConnectedView = null;
-
base.dispose(this.plugin_);
this.plugin_ = null;
};
@@ -481,10 +462,6 @@ remoting.SessionConnectorImpl.prototype.onProtocolExtensionMessage_ =
}
}
- if (remoting.desktopConnectedView) {
- return remoting.desktopConnectedView.handleExtensionMessage(type, message);
- }
-
return false;
};
« no previous file with comments | « remoting/webapp/crd/js/remoting.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698