Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 1016603004: Re-work the 'external snapshot' related build rules. (Closed)

Created:
5 years, 9 months ago by vogelheim
Modified:
5 years, 8 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Re-work the 'external snapshot' related build rules. This prepares for re-landing crrev.com/956373002 This pulls all decision about the snapshot [no|internal|external] into one rule. Previously, this logic was in separate places and not /quite/ the same, which causes build problems. BUG= Committed: https://crrev.com/ee9c738929f2b3195e9486d9e0ec038f031dfce1 Cr-Commit-Position: refs/heads/master@{#27523}

Patch Set 1 #

Patch Set 2 : Fix Win Max build (by using proper rule type) #

Patch Set 3 : Formatting & remove switching the default. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -53 lines) Patch
M test/cctest/cctest.gyp View 1 chunk +1 line, -11 lines 0 comments Download
M test/unittests/unittests.gyp View 1 chunk +1 line, -11 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 2 chunks +45 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
vogelheim
5 years, 9 months ago (2015-03-27 11:36:47 UTC) #2
rmcilroy
lgtm.
5 years, 9 months ago (2015-03-27 16:22:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1016603004/40001
5 years, 8 months ago (2015-03-30 14:53:13 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-03-30 14:54:25 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 14:54:36 UTC) #7
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ee9c738929f2b3195e9486d9e0ec038f031dfce1
Cr-Commit-Position: refs/heads/master@{#27523}

Powered by Google App Engine
This is Rietveld 408576698