Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Unified Diff: test/unittests/unittests.gyp

Issue 1016603004: Re-work the 'external snapshot' related build rules. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Formatting & remove switching the default. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/cctest.gyp ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/unittests.gyp
diff --git a/test/unittests/unittests.gyp b/test/unittests/unittests.gyp
index 2ed05b8adc9fb4111b8253de85e8963086e6fc49..eb5d784857c8239b6a258205ddc399eb74e9701b 100644
--- a/test/unittests/unittests.gyp
+++ b/test/unittests/unittests.gyp
@@ -128,17 +128,7 @@
['component=="shared_library"', {
# compiler-unittests can't be built against a shared library, so we
# need to depend on the underlying static target in that case.
- 'conditions': [
- ['v8_use_snapshot=="true" and v8_use_external_startup_data==0', {
- 'dependencies': ['../../tools/gyp/v8.gyp:v8_snapshot'],
- }],
- ['v8_use_snapshot=="true" and v8_use_external_startup_data==1', {
- 'dependencies': ['../../tools/gyp/v8.gyp:v8_external_snapshot'],
- }],
- ['v8_use_snapshot!="true"', {
- 'dependencies': ['../../tools/gyp/v8.gyp:v8_nosnapshot'],
- }],
- ],
+ 'dependencies': ['../../tools/gyp/v8.gyp:v8_maybe_snapshot'],
}, {
'dependencies': ['../../tools/gyp/v8.gyp:v8'],
}],
« no previous file with comments | « test/cctest/cctest.gyp ('k') | tools/gyp/v8.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698