Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9244)

Unified Diff: chrome/common/mac/app_mode_common.h

Issue 1016543004: [Mac] Use the app's version as the app shim bundle version. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Use GetVersionForDisplay. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/mac/app_mode_chrome_locator.mm ('k') | chrome/common/mac/app_mode_common.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/mac/app_mode_common.h
diff --git a/chrome/common/mac/app_mode_common.h b/chrome/common/mac/app_mode_common.h
index 4e6e07f5b0222f264aa5007b57273b64b62aa5c9..8527583082f2465b0cea1b607fd4e7b24f098a4b 100644
--- a/chrome/common/mac/app_mode_common.h
+++ b/chrome/common/mac/app_mode_common.h
@@ -66,9 +66,18 @@ extern NSString* const kBundleTypeRoleViewer;
// bundles, this overrides the bundle's file name.
extern NSString* const kCFBundleDisplayNameKey;
-// The Chrome version string in the app shim bundle.
+// When Chrome is built, any app bundles (e.g. the app shim template bundle)
+// will have their CFBundleShortVersionString set to the full version string of
+// that build. Since, this string is used by OSX when displaying an app bundle's
+// version, we override it in app shim bundles to show the app's version
+// instead.
extern NSString* const kCFBundleShortVersionStringKey;
+// Key for the Chrome version that built the app shim bundle. This needs to be
+// added since we override CFBundleShortVersionString with the version of the
+// app.
+extern NSString* const kCrBundleVersionKey;
+
// The key specifying whether the display name should be localized. This makes
// Finder look in localization folders in the app bundle for a display name.
// (e.g. Content/Resources/en.lproj/)
« no previous file with comments | « chrome/common/mac/app_mode_chrome_locator.mm ('k') | chrome/common/mac/app_mode_common.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698